Bug Hunting Session
Bug 111082 - Allow change of orientation, by clicking on page image in the page style dialog
Summary: Allow change of orientation, by clicking on page image in the page style dialog
Status: RESOLVED WONTFIX
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.4.0.3 release
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Page-Dialog
  Show dependency treegraph
 
Reported: 2017-08-02 11:16 UTC by Gavin Flower
Modified: 2017-08-12 12:33 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Flower 2017-08-02 11:16:56 UTC
In the pages style dialog, there are radio buttons for the page orientation - I keep wanting to click on the image!

Suggest allow changing the page orientation, by clicking on page image in the page style dialog.  Possibly the image could have two small curved arrows to suggest it could be turned (suggested by buovjaga on IRC).

Probably best to keep the 2 existing radio buttons, to avoid discombobulating experienced users.
Comment 1 Buovjaga 2017-08-02 11:19:00 UTC
Gavin also threw in the idea that the visual clues might only appear upon hover.
Comment 2 Heiko Tietze 2017-08-02 11:38:43 UTC
We prefer "boring" controls because of accessibility. Screen readers do not know about an image and the mnemonics are also suboptimal. Having two ways of user input is acceptable from the a11y POV but where else do we have this type of interaction? IMHO this is a WF. Other opinions?

(component UI -> Writer)
Comment 3 V Stuart Foote 2017-08-02 19:01:28 UTC
Hmm, the thumbnail preview widget already responds to setting any of the values--Format, Width, Height, Orientation, Text direction, Margins and Layout. 

Guess it would be possible to make the preview thumbnail active--but I would not remove any of the existing controls--they are sequenced for keyboar only use and a11y. 

But does it make sense to do so just for the page orientation? Might margins be dragable. 

Note that the same Page Style dialog, in the Borders dialog, we already have the Line Arrangement User-defined preview. That thumbnail widget s active--its sequence of "check-box" events are graphically shown in its preview frame with rendering responding to setting the Line: Style, Width, and Color values on the same dialog tab.
Comment 4 Heiko Tietze 2017-08-10 15:12:39 UTC
We talked about this idea in the design meeting. Real previews are never interactive in LibreOffice. So the decision was to not recommend this enhancement (or change). Anyway, thanks for sharing the ideas.
Comment 5 Gavin Flower 2017-08-10 22:14:00 UTC
I don't consider the image of the page orientation a real preview, but as an indication of how the page is orientated.

A tomato is technically a berry, but most people don't call them berries!  So while in you design lexicon you call it a preview, it does not have to be treated as one!

In programming, meaningful names a Good Thing (TM) - however, sometimes systematic naming is far more appropriate (I first had this insight when I was a COBOL programmer) - so insisting on using meaningful names everywhere is bad!

Please consider how to make LibreOffice more user friendly, rather stick to design rules that are not always appropriate!

So I think it would be advantageous to reverse your decision on this!

Thanks...
Comment 6 Buovjaga 2017-08-11 07:35:31 UTC
(In reply to Heiko Tietze from comment #4)
> We talked about this idea in the design meeting. Real previews are never
> interactive in LibreOffice. So the decision was to not recommend this
> enhancement (or change). Anyway, thanks for sharing the ideas.

Like Gavin, I'm having a hard time understanding this.

What is the definition of a "real preview"? A real preview sounds like something in a graphics application, where you see a live preview of the effect you are about to apply.

As Stuart points out, you can already change stuff by clicking on the preview in the Borders tab.
Comment 7 Heiko Tietze 2017-08-11 07:44:22 UTC
(In reply to Buovjaga from comment #6)
> Like Gavin, I'm having a hard time understanding this.

Exactly because of what Stuart said I used the misleading term "real preview". Despite the border dialog (and maybe other dialogs too) we do not use icons or images as interactive controls. Mainly because of accessibility.

(Made a design proposal myself in the current GSoC project about favorites activated per star icon which was changed into an ordinary button. And actually that worksforme too.)
Comment 8 Gavin Flower 2017-08-12 12:33:53 UTC
Note that the I'm happy for the existing means of changing orientation with Radio Buttons to remain - so adding the ability to click the page icon does not remove functionality needed by the visually impaired.