Bug 111448 - libreoffice calc does not save(or load) position, size and orientation of embedded pictures correctly
Summary: libreoffice calc does not save(or load) position, size and orientation of emb...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
5.1 all versions
Hardware: All All
: medium normal
Assignee: Regina Henschel
URL:
Whiteboard: target:7.1.0
Keywords: bibisected, bisected, filter:xls, regression
Depends on:
Blocks: Calc-Images
  Show dependency treegraph
 
Reported: 2017-08-07 16:46 UTC by farmboy0+libreoffice
Modified: 2020-11-06 16:13 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:


Attachments
xls for the test case (321.50 KB, application/vnd.ms-excel)
2017-08-07 16:47 UTC, farmboy0+libreoffice
Details

Note You need to log in before you can comment on or make changes to this bug.
Description farmboy0+libreoffice 2017-08-07 16:46:16 UTC
Description:
After saving the document in ODS format its layout is destroyed.

Steps to Reproduce:
1.open the attached xls file
2.check the layout of Page 4
3.save the file as ods
4.close LO
5.open the created ods file
6.compare the layout with the original

Actual Results:  
The embedded arrows change in size, position and even orientation.

Expected Results:
I want this shit to look like it was when i saved it.


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0
Comment 1 farmboy0+libreoffice 2017-08-07 16:47:49 UTC
Created attachment 135222 [details]
xls for the test case
Comment 2 farmboy0+libreoffice 2017-08-07 16:51:45 UTC
Additional Info:
This also happens if I edit the created ODS file and move or resize the arrows.
The result when loading the file later after saving it will always be different from what I created.
Comment 3 Julien Nabet 2017-08-07 17:15:51 UTC
Perhaps it would be smart to give a try to a recent LO version?
4.3 branch is EOL (like all 4.X branches, 5.1 and 5.2) so you can give a try to 5.3.4.
Comment 4 Xavier Van Wijmeersch 2017-08-07 17:31:10 UTC
I confirm with

Version: 6.0.0.0.alpha0+
Build ID: e371ec501db0c473bea7ef7325d9a9049f913b5e
CPU threads: 8; OS: Linux 4.9; UI render: default; VCL: kde4; 
Locale: nl-BE (en_US.UTF-8); Calc: group

and

Version: 5.3.4.2
Build ID: SlackBuild for 5.3.4 by Eric Hameleers
CPU Threads: 8; OS Version: Linux 4.9; UI Render: default; VCL: kde4; Layout Engine: new; 
Locale: nl-BE (en_US.UTF-8); Calc: group
Comment 5 farmboy0+libreoffice 2017-08-07 19:34:35 UTC
Corrected version.
Comment 6 Julien Nabet 2017-08-08 17:28:42 UTC
farmboy: Version field must correspond to the oldest version when the bug is encountered.
Comment 7 farmboy0+libreoffice 2017-08-09 01:05:00 UTC
I changed the version to the one for which I reported the error. The original version i gave was an error. I didnt ever use LO4.
Comment 8 Julien Nabet 2017-08-09 20:32:25 UTC
farmerboy: ok then. Anyway, since Xavier confirmed the bug with LO 5.3.4.2 in comment 4, let's put the version accordingly.
Comment 9 QA Administrators 2018-08-10 02:38:42 UTC Comment hidden (obsolete)
Comment 10 farmboy0+libreoffice 2018-08-10 14:19:32 UTC
Still happening with LO 6.0.6.
Comment 11 QA Administrators 2019-10-04 03:06:08 UTC Comment hidden (obsolete)
Comment 12 farmboy0+libreoffice 2019-10-19 11:39:55 UTC
The bug is to some extend still present.

Info from About page:
Version: 6.2.8.2
Build ID: Gentoo official package
CPU threads: 16; OS: Linux 5.3; UI render: default; VCL: kde5; 
Locale: de-DE (de_DE.utf8); UI-Language: en-US
Calc: threaded

To reproduce follow these steps:
1. open the attached xls file
2. note the arrow locations and directions on page 4
3. save the file as ods
4. close calc
5. open the newly saved ods
6. compare with 2.
Comment 13 Xisco Faulí 2019-12-12 11:01:25 UTC
Still reproducible in

Version: 6.5.0.0.alpha0+
Build ID: 4a8d3b80283cec4a93dd697eab70afcb82f04f4f
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded
Comment 14 Xisco Faulí 2019-12-12 11:57:08 UTC
it seems the rotation problem was introduced somewhere in LibreOffice 5.1.
Arrows in page 4 are correctly rotated in 

Version: 5.0.0.0.alpha1+
Build ID: 0db96caf0fcce09b87621c11b584a6d81cc7df86
Locale: ca-ES (ca_ES.UTF-8)

and they are wrong in

Version: 5.2.0.0.alpha0+
Build ID: 3ca42d8d51174010d5e8a32b96e9b4c0b3730a53
Threads 4; Ver: 4.15; Render: default; 

thus, it needs to be bisect with bisect 5.1
Comment 15 raal 2019-12-18 16:23:11 UTC
(In reply to Xisco Faulí from comment #14)
> it seems the rotation problem was introduced somewhere in LibreOffice 5.1.
> Arrows in page 4 are correctly rotated in 

This seems to have begun at the below commit.
Adding Cc: to Henry Castro; Could you possibly take a look at this one? Thanks
 0c9da5d5b253b1322b5cf8ecc109c4b00c13b4aa is the first bad commit
commit 0c9da5d5b253b1322b5cf8ecc109c4b00c13b4aa
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Sat Jul 11 12:56:01 2015 -0700

    source 487880b6882ec01c1b4679eae60bec484272a86b

author	Henry Castro <hcastro@collabora.com>	2015-04-24 16:55:01 -0400
committer	Andras Timar <andras.timar@collabora.com>	2015-05-28 04:59:27 +0000
commit 487880b6882ec01c1b4679eae60bec484272a86b (patch)
tree 7d0c2c7c333ad7f2b86c8f8572ad89652141a790
parent be01d68420086fc36ecf26b5f597ba7c6b29b369 (diff)
Resolves tdf#67712 form controls and draw objects
Comment 16 Regina Henschel 2020-10-29 20:31:33 UTC
It is a file open error with vertical flipped custom shapes.

Proposed patch is in https://gerrit.libreoffice.org/c/core/+/104643. Waiting for review.
Comment 17 Regina Henschel 2020-10-31 16:59:14 UTC
Should be fixed with https://cgit.freedesktop.org/libreoffice/core/commit/?id=1f0b3c7a40edfa81bbc7a58d123a6a2dfd83e4ca

(The patch covers several bug reports, therefore no automatic notification.)

I set this to fixed. In case you still see problems, please write a new bug report and attach a _small_ file, which shows the error.
Comment 18 Xisco Faulí 2020-11-06 16:13:15 UTC
Verified in

Version: 7.1.0.0.alpha1+
Build ID: 9c8ed8c8526b9b696d0bf592eb7d963950f3cef4
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: x11
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Regina, thanks for fixing this issue!!