Bug 111751 - Small rendering issue of Language value on font tab page
Summary: Small rendering issue of Language value on font tab page
Status: RESOLVED WONTFIX
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
4.2 all versions
Hardware: All All
: medium trivial
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyBeginner, easyHack, skillCpp, topicUI
Depends on:
Blocks:
 
Reported: 2017-08-13 00:56 UTC by Tamás Zolnai
Modified: 2017-11-05 15:30 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

Attachments
Screenshot showing the whitespace (20.78 KB, image/png)
2017-08-13 00:57 UTC, Tamás Zolnai 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tamás Zolnai 2017-08-13 00:56:53 UTC 
Description:
On font tab page (for example on Character Properties dialog) the different font languages are displayed differently. Compare the Western Text Font and Asian Text Font language field. For Asian Font there is some additional space before the selected language while for Western Font there is nothing like that. The same white space is there in the list when you open the combobox.

Would be good to avoid adding that additional white space, since it's no purpose (It's a good easy hack candidate)

Steps to Reproduce:
1. Open any properties dialog which has font tab page


Actual Results:  
Asian Font language is displayed with some additional whitespace before it.

Expected Results:
Additional whitespaces should be removed both from the edit field of the combobox and also from the list of the combobox.


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.90 Safari/537.36
Comment 1 Tamás Zolnai 2017-08-13 00:57:14 UTC 
Created attachment 135507 [details]
Screenshot showing the whitespace
Comment 2 Xisco Faulí 2017-08-15 17:21:42 UTC 
Reproduced in

Version: 6.0.0.0.alpha0+
Build ID: ef2e6260fad38e26c8591ea88ded348db618270d
CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

and back to

Version: 4.1.0.0.alpha1+
Build ID: a2c9d4f8bbde97f175bae4df771273a61251f40

I guess in the pass there was an icon displayed in that space...
Comment 3 Tamás Zolnai 2017-08-26 11:46:41 UTC 
I checked it again. It seems sometimes an icon is displayed next to the language name in the list. It must be something related to available spellchecker. So it's functional that we have that additional space in the list items.
However what we can fix here is the inconsistency of the different language boxes. The difference comes from that Western language box is combox (you can type in the field), while the other two are simple listboxes. Since combobox has a feature of that we can find item faster by typing the first characters, it would be the best to convert the other two language box also to a combobox, so they will display languages consistently.
Comment 4 Tamás Zolnai 2017-08-26 11:49:43 UTC 
Let's turn this into a easy hack. The code is here:
cui/uiconfig/ui/charnamepage.ui -> defines the structure of the font page
cui/source/tabpages/chardlg.cxx -> implementation of the font page
Comment 5 Tamás Zolnai 2017-08-26 11:51:47 UTC 
(In reply to Tamás Zolnai from comment #4)
> Let's turn this into a easy hack. The code is here:
> cui/uiconfig/ui/charnamepage.ui -> defines the structure of the font page
> cui/source/tabpages/chardlg.cxx -> implementation of the font page

The task here to convert Asian and CTL font language boxes to comboboxes (the same combobox type as Western language box has)
Comment 6 Tamás Zolnai 2017-11-05 15:30:04 UTC 
Better to close this bug. It's not clear which widget is the best to use for language boxes.