Bug 111841 - Increase / decrease font size buttons create two undo action when clicking on them
Summary: Increase / decrease font size buttons create two undo action when clicking on...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
4.1.0.4 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisectRequest, regression
Depends on:
Blocks: Undo-Redo Font-Size
  Show dependency treegraph
 
Reported: 2017-08-16 02:07 UTC by Tamás Zolnai
Modified: 2023-08-07 03:46 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot showing whch undo actions are added (91.05 KB, image/png)
2017-08-16 02:10 UTC, Tamás Zolnai
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tamás Zolnai 2017-08-16 02:07:30 UTC
Description:
With increase / decrease font you can change the font size of a shape. The issue here is that after you applied a size change two undo action are inserted to the undo stack and so you need to click undo twice to revert the font size change.

Steps to Reproduce:
1. Open Impress
2. Select Titel shape
3. Click on increase font or decrease font button (undo action list gets two items)
4. Click undo -> nothing happens
5. Click undo again -> font size change is reverted

Actual Results:  
Two undo action is inserted to the list when the increase / decrease button is pushed and so needs two apply undo twice to revert the font size change.

Expected Results:
One undo item should be created and so one undo should be enough to revert a font size change.


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.90 Safari/537.36
Comment 1 Tamás Zolnai 2017-08-16 02:10:09 UTC
Created attachment 135570 [details]
Screenshot showing whch undo actions are added
Comment 2 Telesto 2017-08-16 09:45:14 UTC
Repro with:
Version: 6.0.0.0.alpha0+
Build ID: f1a896c71c495bdef5861eb664581507b6b9b5bb
CPU threads: 4; OS: Windows 6.19; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-08-13_07:38:19
Locale: nl-NL (nl_NL); Calc: CL
Comment 3 Telesto 2017-08-16 09:49:04 UTC
Probably a little bit easier to notice
1. Open Impress
2. Select Title shape
3. Type something into the textbox
4. Apply a font color
5. Undo applying font (CTRL+Z) -> no effect
6. Undo a second time (CTRL+Z) -> working
Comment 4 QA Administrators 2018-08-17 02:38:18 UTC Comment hidden (obsolete)
Comment 5 QA Administrators 2020-10-29 04:32:43 UTC Comment hidden (obsolete)
Comment 6 QA Administrators 2022-10-30 03:46:27 UTC Comment hidden (obsolete)
Comment 7 Stéphane Guillou (stragu) 2023-07-04 09:08:55 UTC
Still repro in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: e4e5fb4b2935e395c7e4b3a794d544a6f44709ce
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Regression as it is not in OOo 3.3 (testing with toolbar buttons in Impress).
Comment 8 Aron Budea 2023-08-07 03:46:55 UTC
Already in 4.1.0.4, not in 4.0.0.3. Checked with original steps.

(In reply to Telesto from comment #3)
> Probably a little bit easier to notice
> 1. Open Impress
> 2. Select Title shape
> 3. Type something into the textbox
> 4. Apply a font color
> 5. Undo applying font (CTRL+Z) -> no effect
> 6. Undo a second time (CTRL+Z) -> working
This is already in 3.3.0, so a different issue, let's not mix up the two.