Bug 111959 - Unnecessary selection activity after a change of locale which forces a change of separator character
Summary: Unnecessary selection activity after a change of locale which forces a change...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
5.0.2.2 release
Hardware: x86 (IA32) Windows (All)
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Decimal-Separator-Key
  Show dependency tree / graph
 
Reported: 2017-08-22 08:26 UTC by Luis
Modified: 2023-04-24 05:36 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luis 2017-08-22 08:26:57 UTC 
In calc when changing locale if the separator character is not valid then the separator in formulas are changed automatically. 
When this happen there is a stange behaviour.

1) Create a new file with locale set to "English (USA)"

In this locale the separator is ","

2) Insert in cell A1 the formula

=LEFT("Text",2)

3) Change locale to "Spanish (Spain)"

In this locale the separator can't be "," so is changed to ";"

4) Press the mouse over cell A1 

The application then shows a message about change separator character and when you accept a range of cells becomes selected moving the mouse changes the selection as if the shift key was pressed.
Comment 1 Buovjaga 2017-09-02 17:36:19 UTC 
This only happens on Windows.

On Linux, the message is displayed after step 3.

I tried to bibisect it, but hit an error with some python cache causing changes.. I asked for help from Xisco.

Arch Linux 64-bit, KDE Plasma 5
Version: 6.0.0.0.alpha0+
Build ID: 4082b5874adddedf8332fe977b6bb47b6949b302
CPU threads: 8; OS: Linux 4.12; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on August 31st 2017

Win 10
Version: 6.0.0.0.alpha0+ (x64)
Build ID: 4b4ebb15456af443347679a7e7e8726c090a5bf5
CPU threads: 4; OS: Windows 6.19; UI render: default; 
TinderBox: Win-x86_64@62-TDF, Branch:master, Time: 2017-08-31_02:04:11
Locale: es-ES (fi_FI); Calc: group
Comment 2 Buovjaga 2017-09-05 17:46:37 UTC 
Bibisect went ok after I removed the python cache files.

Apparently this is the first bad commit, adding Michael M. to CC: https://cgit.freedesktop.org/libreoffice/core/commit/?id=7aae8772aa18744cb1bbd8348272be99cc882c47
 ba5c12eeb1977bd3f7466df16a94b4c6f9523f6e is the first bad commit
commit ba5c12eeb1977bd3f7466df16a94b4c6f9523f6e
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Tue Jul 14 14:13:07 2015 -0700

    source 7aae8772aa18744cb1bbd8348272be99cc882c47

    source 7aae8772aa18744cb1bbd8348272be99cc882c47

:040000 040000 585263ef01040b84876a862f697845c7f2435edf 45e0fefb5f34497a31fce6cb9e1a52b558c143a4 M      instdir


# bad: [05d11632892a322664fb52bac90b2598b7fb7544] source 5616d22b57a9a5e57d545e912e029162a230829b
# good: [c1efd324c6ad448ac9edb030dc9738b9e6899e4d] source ab465b90f6c6da5595393a0ba73f33a1e71a2b65
git bisect start 'master' 'oldest'
# bad: [97526ab777da7e58ce283c05498262ecdd4d6f7f] source 4ea70f87f7a2b61eda6e5ab1f48debf6fcfadc1f
git bisect bad 97526ab777da7e58ce283c05498262ecdd4d6f7f
# bad: [2202cdaa0eae3f646f1285a0ea45934edeb26e8a] source a88bf8fd10c42a15e5d6e66da656889c82b4933a
git bisect bad 2202cdaa0eae3f646f1285a0ea45934edeb26e8a
# bad: [1d0a95445c203c11beb1aa5eae844cf178ea0984] source 8f324aebfb94c4b2023894121b954ad4f35eb395
git bisect bad 1d0a95445c203c11beb1aa5eae844cf178ea0984
# good: [fb2523235c0a0c37d4e1f482afde48066f2c4b83] source 5b87ff40857147bee697a9bf420aae89e8cd9e93
git bisect good fb2523235c0a0c37d4e1f482afde48066f2c4b83
# bad: [96c5e6142c03cdfdd63c936de319666d0fdcffcc] source b2c8ea3a0253ce87f1b292fbb19b461a53c14912
git bisect bad 96c5e6142c03cdfdd63c936de319666d0fdcffcc
# good: [c630e487b748e18b8aa9489d1b4bc96ec749af2b] source 374d53f5ee0204b17b76a1f447b041ce5479971d
git bisect good c630e487b748e18b8aa9489d1b4bc96ec749af2b
# bad: [195e133babd8ef9d963328e73411a822019e514b] source 4101949b2a9fcf399a1fa10c2547f745a24f5a3d
git bisect bad 195e133babd8ef9d963328e73411a822019e514b
# good: [938ff6f34bfb99a36e8a7a01caef827a7aef7705] source 2f6a06856ad8df0c11a112d1e457b408e9a7af1d
git bisect good 938ff6f34bfb99a36e8a7a01caef827a7aef7705
# bad: [23aafef6874e33d735f33844fbf6a05394d6885f] source 2da066628f02925ade2590229eb069d4765f619a
git bisect bad 23aafef6874e33d735f33844fbf6a05394d6885f
# bad: [f57734c0b0554aad874a3d311db01321cc127898] source 373c276e8ac2550aacaca855ba4d3e89b3e2f2ca
git bisect bad f57734c0b0554aad874a3d311db01321cc127898
# bad: [ba5c12eeb1977bd3f7466df16a94b4c6f9523f6e] source 7aae8772aa18744cb1bbd8348272be99cc882c47
git bisect bad ba5c12eeb1977bd3f7466df16a94b4c6f9523f6e
# good: [2b865f25e22deb81729dcd00aa280772b804a278] source 621ab8571ee99b0d425cfb88892898884edb2eec
git bisect good 2b865f25e22deb81729dcd00aa280772b804a278
# good: [0acaabbd5380ddba5409f0228386c51a493cb660] source b9f95769495e8d9885b64f1d68118336a4fc8d38
git bisect good 0acaabbd5380ddba5409f0228386c51a493cb660
# first bad commit: [ba5c12eeb1977bd3f7466df16a94b4c6f9523f6e] source 7aae8772aa18744cb1bbd8348272be99cc882c47
Comment 3 Buovjaga 2017-09-05 18:27:34 UTC 
Áron urged me to verify by checking out the commit in the bibisect repo and then HEAD~1 (previous commit). I repro with the blamed commit, but not the previous.
Comment 4 Xisco Faulí 2017-09-05 22:18:28 UTC Comment hidden (obsolete)
Comment 5 Michael Meeks 2017-09-08 17:03:42 UTC 
Well - it is a great bisection =) however - it is really unclear what is happening there. Possibly the destruction lifecyľe of the window changed somehow - such that some mouse event is triggered on the underlying window instead of this message dialog on top.

If you move the "shows a message about change separator character" - so that it is not above the underlying window - does that affect behavior ? =)

Thanks !
Comment 6 Buovjaga 2017-09-08 17:12:59 UTC 
(In reply to Michael Meeks from comment #5)
> If you move the "shows a message about change separator character" - so that
> it is not above the underlying window - does that affect behavior ? =)

Just tried it, but it does not affect the behavior.
Comment 7 Buovjaga 2017-09-09 08:42:32 UTC 
I think the crucial distinction is this:
It used to show the message right after changing the option.

Now it shows the message, when you click the cell.

It appears the mouse click gets stuck at this point.
Comment 8 QA Administrators 2018-09-10 02:37:03 UTC Comment hidden (obsolete)
Comment 9 QA Administrators 2020-09-10 03:57:10 UTC Comment hidden (obsolete)
Comment 10 QA Administrators 2022-09-11 03:42:15 UTC Comment hidden (obsolete)
Comment 11 ady 2023-04-24 05:36:52 UTC 
I could not repro. I think this is WFM by now, but considering prior comments, I don't want to set it to WFM unless someone else that already reproduced this in the past can confirm that it is working as expected in the same context (OS, precise steps, locale, decimal separator, file format, UI language...).