Bug 112028 - ReleasePoolHolder() doesn't completely release all objects
Summary: ReleasePoolHolder() doesn't completely release all objects
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha0+
Hardware: x86-64 (AMD64) macOS (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-25 14:41 UTC by Alex Thurgood
Modified: 2019-08-09 09:05 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Refcount cycle screenshot (91.15 KB, image/png)
2017-08-25 14:42 UTC, Alex Thurgood
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Thurgood 2017-08-25 14:41:02 UTC
Description:
ReleasePoolHolder() doesn't completely release all objects held in memory leading to gradual increase in memory consumption

Steps to Reproduce:
1. Open Writer document
2. Open "Find" dialog
3. Close "Find" dialog
4. Repeat step 3 multiple times

Actual Results:  
Ref count shows that not all memory released

Expected Results:
Memory should be released correctly


Reproducible: Always

User Profile Reset: No

Additional Info:
Instruments.app points (OSX memory profiler) points to line 41 in saltimer.h :

    ~ReleasePoolHolder() { [mpPool release]; }





User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:54.0) Gecko/20100101 Firefox/54.0
Comment 1 Alex Thurgood 2017-08-25 14:42:46 UTC
Created attachment 135789 [details]
Refcount cycle screenshot

The screenshot shows the refcount cycle for ReleasePool
Comment 2 Alex Thurgood 2017-08-25 14:44:04 UTC
No idea why the count suddenly jumps from 1 back up to 2 when it is supposed to be decrementing...
Comment 3 Julien Nabet 2017-08-25 14:56:55 UTC
Jan-Marek: having noticed your commit in saltimer history, thought you might be interested in this one.
Comment 4 Telesto 2017-08-25 17:30:56 UTC
Confirming with 5.4.1.1
Comment 5 QA Administrators 2018-08-26 02:39:24 UTC Comment hidden (obsolete)
Comment 6 Alex Thurgood 2019-08-09 09:05:12 UTC
Not seeing this anymore with current master build.