Bug 112030 - EMF gradients are blocky on Linux, if VCL backend is not GTK3
Summary: EMF gradients are blocky on Linux, if VCL backend is not GTK3
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: filters and storage (show other bugs)
Version:
(earliest affected)
4.2 all versions
Hardware: All Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: EMF-WMF
  Show dependency treegraph
 
Reported: 2017-08-25 17:43 UTC by Buovjaga
Modified: 2023-02-04 17:22 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Blocky gradients (9.65 KB, image/png)
2017-09-05 08:10 UTC, Buovjaga
Details
No blockiness here (75.84 KB, image/png)
2017-09-05 08:23 UTC, Xisco Faulí
Details
The example file under gen in recent master (198.05 KB, image/png)
2023-02-04 17:15 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Buovjaga 2017-08-25 17:43:00 UTC
Download attachment 67335 [details] from bug 55058 and open on Linux.

The gradients are not blocky on 3.6.

Armin said they look the same on 5.2 and current, I confirm blockiness on 5.4 and master.

Arch Linux 64-bit
Version 3.6.7.2 (Build ID: e183d5b)

Arch Linux 64-bit, KDE Plasma 5
Version: 6.0.0.0.alpha0+
Build ID: 485fcd4f367ebdf5a7494976424e64c7c68ff450
CPU threads: 8; OS: Linux 4.12; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on August 25th 2017
Comment 1 Jean-Baptiste Faure 2017-09-05 06:41:18 UTC
What does mean "gradients are blocky" ?

Set status to NEEDINFO, please set it back to UNCONFIRMED once requested
informations are provided.

Best regards. JBF
Comment 2 Buovjaga 2017-09-05 08:10:35 UTC
Created attachment 136024 [details]
Blocky gradients

They should be smooth, but are instead composed of blocks of solid colors.
Comment 3 Xisco Faulí 2017-09-05 08:23:10 UTC
Created attachment 136025 [details]
No blockiness here

How I see it in

Version: 6.0.0.0.alpha0+
Build ID: 04d70c0999c716f5465631eca50945915ec607c4
CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group
Comment 4 Buovjaga 2017-09-05 08:29:30 UTC
(In reply to Xisco Faulí from comment #3)
> Created attachment 136025 [details]
> No blockiness here
> 
> How I see it in
> 
> Version: 6.0.0.0.alpha0+
> Build ID: 04d70c0999c716f5465631eca50945915ec607c4
> CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; 
> Locale: ca-ES (ca_ES.UTF-8); Calc: group

Ah, it is dependent on VCL backend! GTK3 wins this time, but all the others lose.
Comment 5 Xisco Faulí 2017-09-05 12:07:17 UTC
Confirmed in

Version: 6.0.0.0.alpha0+
Build ID: 04d70c0999c716f5465631eca50945915ec607c4
CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk2; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group
Comment 6 Xisco Faulí 2017-09-05 12:18:38 UTC
Regression introduced by:

author	Armin Le Grand <alg@apache.org>	2013-01-14 13:02:48 (GMT)
committer	Caolán McNamara <caolanm@redhat.com>	2013-06-13 14:46:44 (GMT)
commit 45a8eaf9c55f2686f69118641d8a8992a86dfe31 (patch)
tree c8dc047f2c9e63cb44d44288c87c27763e958f7c
parent b0f10dd3262cd16b8a6c1bb4fbc3386330acc685 (diff)
Resolves: #i121534# Adapted rotated bitmap paints to use own transformer...
due to bad quality of GraphicManager paints

(cherry picked from commit f4887567cc71dca520d57cb6ff2b40eb49142cda)

Conflicts:
	drawinglayer/source/processor2d/vclhelperbitmaprender.cxx

Bisected with bibisect-42max

Adding Cc: to Armin Le Grand
Comment 7 Armin Le Grand 2022-01-04 14:40:21 UTC
This commit was developed for another code base, and not merged by me. For complex changes like this, side-effects are to be expected; sadly I dont't have the cycles to deal with all the fallout. Un-Ccing myself for the while.
Comment 8 Gabor Kelemen (allotropia) 2023-02-04 17:15:40 UTC
Created attachment 185108 [details]
The example file under gen in recent master

This is no longer blocky in

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 6d1ba1877ac1e8d77748b238a7706e3a4f8d9ed4
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: x11
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded

since:
https://git.libreoffice.org/core/+/6d1ba1877ac1e8d77748b238a7706e3a4f8d9ed4

author	Caolán McNamara <caolanm@redhat.com>	Tue Jan 10 15:18:40 2023 +0000
committer	Caolán McNamara <caolanm@redhat.com>	Wed Jan 11 10:33:48 2023 +0000

use SvpSalBitmap for X11/gen also
Comment 9 Gabor Kelemen (allotropia) 2023-02-04 17:22:01 UTC
Thanks Caolán for fixing this!

(the bottom right black-white, white-black squares are still grey-white, white-grey like on the first screenshot - that's probably another bug)