Bug 112074 - FILEOPEN: DOC: RTL indented table placed with a negative indent on left instead of on the right
Summary: FILEOPEN: DOC: RTL indented table placed with a negative indent on left inste...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Justin L
URL:
Whiteboard: target:6.0.0
Keywords:
Depends on:
Blocks: DOC-RTL
  Show dependency treegraph
 
Reported: 2017-08-28 21:10 UTC by Justin L
Modified: 2024-08-19 13:13 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
RTL_table_indent.doc: table should be aligned 1cm from right, not -1cm from left (24.00 KB, application/msword)
2017-08-28 21:10 UTC, Justin L
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Justin L 2017-08-28 21:10:32 UTC
Created attachment 135833 [details]
RTL_table_indent.doc: table should be aligned 1cm from right, not -1cm from left

Tables that are indented have "From Left" alignment. That gets a bit trickier when importing .DOC Right-To-Left tables - where a physical "Right" alignment needs to be converted into a "From Left" alignment. That ought to be starting at position = pageTextWidth - tableWidth - Indent.  Currently it is starting at position = LeftMargin - Indent.

The code section involved originally came from these OOo issues:
https://bz.apache.org/ooo/attachment.cgi?id=58087&action=diff
    for bug https://bz.apache.org/ooo/show_bug.cgi?id=28656

and https://bz.apache.org/ooo/attachment.cgi?id=63705&action=diff
    for bug https://bz.apache.org/ooo/show_bug.cgi?id=103357
Comment 1 Justin L 2017-08-29 02:42:55 UTC
proposed fixes:

https://gerrit.libreoffice.org/41664 tdf#112074 doc import: use real width if no preferred width

https://gerrit.libreoffice.org/41665 tdf#112074 doc export: for RTL tables, LEFT_AND_WIDTH is RIGHT

https://gerrit.libreoffice.org/41666 tdf#112074 doc export: re-calculate indent for RTL table
Comment 2 Commit Notification 2017-09-06 07:09:06 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=176a723876b0138debb20f824103b2ab0c910401

tdf#112074 doc import: use real width if no preferred width

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2017-09-07 09:30:19 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=f091460837835033b10df7674210b0856cda0ec9

tdf#112074 doc export: for RTL tables, LEFT_AND_WIDTH is RIGHT

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2017-09-08 10:19:42 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=3c29b0ad690c77b2ec9189981da73ffaa717e30c

tdf#112074 doc export: re-calculate indent for RTL table

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2017-09-09 14:08:26 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=7ed6bcc714ed0e4f23031c1cbc16176b3549e391

tdf#112074 ww8import: replace m_nOrgDxaLeft with GetMinLeft()

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.