Bug 112369 - Improve the workflow of adding items to menus
Summary: Improve the workflow of adding items to menus
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: topicUI
Depends on:
Blocks: Customize-Dialog
  Show dependency tree / graph
 
Reported: 2017-09-13 10:37 UTC by Muhammet Kara
Modified: 2017-10-24 15:50 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Muhammet Kara 2017-09-13 10:37:37 UTC 
This is a spin off from https://bugs.documentfoundation.org/show_bug.cgi?id=112133

 Muhammet Kara 2017-09-13 10:09:37 UTC
(In reply to Heiko Tietze from comment #12)
> When adding a command to a menu or context menu that already contains this
> items a confirmation box is shown telling the user that this operation is
> not possible. Not the best approach, and you better disable the add button.

This requires some more dev effort than the polishing task itself requires. Let's separate it.

Instead of checking for duplicates after pressing the add button, we may check for duplicates in SvxMenuConfigPage::UpdateButtonStates(), and make sure it is called from both SelectMenu and SelectFunctionHdl.

Note that SelectMenu is in SvxMenuConfigConfigPage, while SelectFunctionHdl is in SvxConfigPage. So it might be a good idea to move one of them to the parent or to the child class.