Bug 112417 - UI - Insert Sheet called when clicking anywhere on the footer
Summary: UI - Insert Sheet called when clicking anywhere on the footer
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL: https://ask.libreoffice.org/t/can-no-...
Whiteboard: target:7.6.0
Keywords: difficultyBeginner, easyHack, skillCpp, topicUI
Depends on:
Blocks: Sheet-Tabs-Bar
  Show dependency treegraph
 
Reported: 2017-09-16 00:13 UTC by mike.ely
Modified: 2024-09-30 05:33 UTC (History)
10 users (show)

See Also:
Crash report or crash signature:


Attachments
Short clip demonstrating the problem (4.60 MB, video/webm)
2017-09-18 15:41 UTC, mike.ely
Details

Note You need to log in before you can comment on or make changes to this bug.
Description mike.ely 2017-09-16 00:13:19 UTC
When working with many windows one sometimes the most convenient way to bring Calc to the foreground is to click on the footer (titlebar not visible etc). Unfortunately any part of the footer area not containing a control defaults to Insert Sheet, spawning a dialogue that must be cleared in order to continue work.

Expected behavior: clicking a blank area in the footer has no impact beyond bringing the window to focus. Insert Sheet is called by clicking the + sign.
Comment 1 Xisco Faulí 2017-09-17 10:05:03 UTC
Could you please create a screenshot or screencast showing the problem?
It's unclear to me what the problem is here.
Comment 2 mike.ely 2017-09-18 15:41:36 UTC
Created attachment 136342 [details]
Short clip demonstrating the problem

In the attached clip I'm demonstrating the issue - Calc is running behind a Konsole window. I show two ways of switching focus to Calc without triggering the problem before clicking in the region where the Insert Sheet dialogue is improperly called. I then demonstrate by clicking the + sign the right place to call that dialogue (or perhaps just from Insert... Sheet).

The bottom of the main window shouldn't trigger a modal window unless a specific widget is selected. The current behavior is unexpected and intrusive.
Comment 3 Jean-Baptiste Faure 2017-09-26 20:11:08 UTC
Reproducible with LO 5.4.1 from Ubuntu PPA, 5.4.3.0.0+ and master both built at home under Ubuntu 16.04 x86-64.

I agree that that is an unexpected behavior. Setting as NEW.

Best regards. JBF
Comment 4 QA Administrators 2018-09-27 02:42:12 UTC Comment hidden (obsolete)
Comment 5 BogdanB 2018-09-27 05:10:55 UTC
This bug should be simple to solve:
- if the bottom bar it is suposed to be used to add sheets, this is not a bug, and the person who want to focus on another window should click on sheets not at bottom, as he did in the video at first.
- if the bottom bar it is NOT suposed to be used to add sheets that function should be removed from the bar and let only to the plus sign.
Comment 6 QA Administrators 2019-09-28 03:04:24 UTC Comment hidden (obsolete)
Comment 7 Jean-Baptiste Faure 2019-10-13 18:17:18 UTC
Still reproducible in Version: 6.3.4.0.0+
Build ID: edcb363f5eeefcc2ce28a2ab7a57d61b744466cd
Threads CPU : 4; OS : Linux 4.15; UI Render : par défaut; VCL: gtk3; 
Ubuntu_18.04_x86-64
Locale : fr-FR (fr_FR.UTF-8); Langue IHM : fr-FR
Calc: threaded

Best regards. JBF
Comment 8 QA Administrators 2021-10-13 03:40:10 UTC Comment hidden (obsolete)
Comment 9 Jean-Baptiste Faure 2021-10-13 13:55:57 UTC
Still reproducible with LO 7.2 and current master.

Best regards. JBF
Comment 10 Heiko Tietze 2022-11-23 08:49:07 UTC
I agree with JBF, it's not common.

If more than one sheet is selected, clicking the empty area deselects (see https://bz.apache.org/ooo/show_bug.cgi?id=70320). I think we can keep this function.

Code pointer is ScTabControl::MouseButtonUp() in sc/source/ui/view/tabcont.cxx, task is to remove FID_INS_TABLE.
Comment 11 Radhey Parekh 2023-01-05 17:26:46 UTC
I would like to work on this. Assigning it to myself, thanks.
Comment 12 Commit Notification 2023-01-16 08:00:18 UTC
Radhey Parekh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4114218584bca3267aff474a7b55a9d5891fcce6

tdf#112417 Insert Sheet called when clicking anywhere on the footer

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 BogdanB 2023-01-21 19:53:43 UTC
Now, clicking in the footer doesn't trigger a new sheet. It's ok.

Verified with
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 24c9373409dda957ad6e1f1b4e3ec6c7135ecf1a
CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 14 Shantanu 2024-09-30 04:12:32 UTC
"double" clicking in the footer should trigger a new sheet. Is that possible?
Comment 15 Buovjaga 2024-09-30 05:33:41 UTC
(In reply to Shantanu from comment #14)
> "double" clicking in the footer should trigger a new sheet. Is that possible?

It sounds like the famous case of the overheating spacebar: https://xkcd.com/1172/

Up to the user experience design team to decide.