Bug 112747 - MacSpellChecker::getLocales() leaks with multiple invocations
Summary: MacSpellChecker::getLocales() leaks with multiple invocations
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha0+
Hardware: All macOS (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-29 08:20 UTC by Telesto
Modified: 2020-05-10 08:32 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
BT & Few screenshots (571.38 KB, application/x-zip-compressed)
2017-09-29 08:21 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2017-09-29 08:20:56 UTC
Description:
MacSpellChecker::getLocales()  leaks with multiple invocations 

Steps to Reproduce:
1. Start the Instruments
2. Choose Memory Leak profile tool
3. Select LibreOffice.app in instdir as target process
4. Click on the record button, LODev is started by the profiling tool
5. Wait for the StartCenter to load.
6. Go to LibreOffceDev -> Preferences 
7. Open LibreOffceDev ->Writing Aids
8. Writing add -> Edit
9. Close dialog
10. Close preference dialog
11. Stop recording.
12. Analyse the profile trace.

Actual Results:  
MacSpellChecker::getLocales()  leaks with multiple invocations 

Expected Results:
Shouldn't happen


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0
Comment 1 Telesto 2017-09-29 08:21:19 UTC
Created attachment 136606 [details]
BT & Few screenshots
Comment 2 Alex Thurgood 2017-10-02 14:59:25 UTC
Several possibilities:

SvTreeListEntry* SvxEditModulesDlg::CreateEntry( OUString& rTxt, sal_uInt16 nCol )
{
    SvTreeListEntry* pEntry = new SvTreeListEntry;
    if( !pCheckButtonData )
    {
        pCheckButtonData = new SvLBoxButtonData(m_pModulesCLB);
        pCheckButtonData->SetLink( LINK( this, SvxEditModulesDlg, BoxCheckButtonHdl_Impl2 ) );
    }

in optlingu.cxx lines 1837-1844

with

        pCheckButtonData = new SvLBoxButtonData(m_pModulesCLB);

being singled out by memleak tool
Comment 3 Alex Thurgood 2017-10-02 15:00:52 UTC
Also,

SvLBoxButtonData::SvLBoxButtonData( const Control* pControlForSettings )
    : pImpl( new SvLBoxButtonData_Impl )
{
    InitData( false, pControlForSettings );
}


lines 51-55 in svlbitm.cxx
Comment 4 Julien Nabet 2017-10-02 15:26:38 UTC
Alex: great! In this case, it could be already fixed now thanks to Caolán's patch https://cgit.freedesktop.org/libreoffice/core/commit/?id=e1f87cb067a058f34caaf61d86c79958eebfd0e4
Comment 5 QA Administrators 2018-10-03 02:53:43 UTC
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug