Bug 112981 - LibreOffice is not closed if restart dialog reminds open
Summary: LibreOffice is not closed if restart dialog reminds open
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
5.4.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:6.0.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2017-10-07 18:07 UTC by Xisco Faulí
Modified: 2017-10-24 07:02 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2017-10-07 18:07:29 UTC 
Steps to reproduce:
1. Install an extension
2. Once it's install, close the extension dialog -> at this point a dialog suggesting to restart LibreOffice is prompted ( DO NOT CLOSE IT )
3. Close the main window

Observed behaviour: LibreOffice disappears but the process is still running. it needs to be killed from the console or the system monitor

Reproduced in

Version: 6.0.0.0.alpha0+
Build ID: ad439ded005cffd525ffe874f535fca7a4da1f49
CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

and

Version: 5.3.0.0.alpha1+
Build ID: 4136757b4e51c4e6f7cb4132c95538a7f831ef2c
CPU Threads: 4; OS Version: Linux 4.10; UI Render: default; VCL: gtk3; Layout Engine: new; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

but not in because the restart dialog is not displayed

Version: 5.2.0.0.alpha1+
Build ID: 5b168b3fa568e48e795234dc5fa454bf24c9805e
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; 
Locale: ca-ES (ca_ES.UTF-8)
Comment 1 raal 2017-10-08 06:54:25 UTC 
The restart dialog came with this commit.
Adding Cc: to irem ; Could you possibly take a look at this one? Thanks

author	irem <iremsendur1@gmail.com>	2016-05-23 08:43:44 (GMT)
committer	jan iversen <jani@documentfoundation.org>	2016-06-23 06:44:23 (GMT)
commit 2c1056d679187a702bad3a2ba5dcb6b068e1aa5e (patch)
tree 7682b83bbcb550e903bd686a690253f100988a85
parent aa0d0536a444fb26d9e570bd6bf6c1bdc3596cf3 (diff)
tdf#46279 Show restart message after extension installation
Change-Id: I91feab63b77055b8f73d0fb481a76586b249160c
Reviewed-on: https://gerrit.libreoffice.org/24595
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Comment 2 Xisco Faulí 2017-10-08 11:02:26 UTC 
Caolán, one for you ? As you fixed bug 111760 in the past, I thought this bug could be similar ...
Comment 3 Caolán McNamara 2017-10-18 20:07:29 UTC 
https://cgit.freedesktop.org/libreoffice/core/commit/?id=3db8059cd92545a618e6ec349b090b569c60847d should make the restart dialog modal  to the background frame so then can't end up in this situation
Comment 4 Xisco Faulí 2017-10-24 07:02:51 UTC 
Verified in

Version: 6.0.0.0.alpha1+
Build ID: 43d6b11a5c1dda0cc2c1e06c768eece25051a56c
CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group