Bug 113084 - FILEOPEN: RTF - Font table not imported/applied correctly
Summary: FILEOPEN: RTF - Font table not imported/applied correctly
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
3.5.0 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: filter:rtf, preBibisect, regression
Depends on:
Blocks: Fonts RTF-Character RTF-New-Import
  Show dependency treegraph
 
Reported: 2017-10-12 23:37 UTC by Yousuf Philips (jay) (retired)
Modified: 2021-03-05 01:05 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2017-10-12 23:37:52 UTC
steps
1. open attachment 83389 [details]
2. notice the font is set to the default CTL font (for me it was Lucida Sans) instead of Orkun
3. move cursor to the beginning of the '(1)' line and notice the font hasnt changed instead of being Helvetica
4. move cursor next to any colon and font hasnt changed instead of being Helvetica

Regression as this was imported correctly with the old 3.3 rtf importer. LO 3.5 and 3.6 wouldnt import any of the RTL text, though it did correctly import the non-RTL text as Helvetica.

Font table rtf text
'{\fonttbl\f0\fnil\fcharset0 Orkun;\f1\fswiss\fcharset0 Helvetica;}'

Helvetica colon rtf text
'\f1  : '

Version: 6.0.0.0.alpha0+
Build ID: 4d1ee296def5fde9c77702d3d19d76be33cbdaad
CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk2; 
Locale: en-US (en_US.UTF-8); Calc: group
Comment 1 Xisco Faulí 2017-10-27 09:22:42 UTC
I trust you ;-)
Comment 2 Buovjaga 2018-07-01 17:45:22 UTC
So the target of the bibisectRequest was apparently about the Helvetica change. In 43all repo with Ubuntu 14.04, the font just stays Helvetica everywhere.
Comment 3 Buovjaga 2019-01-04 20:37:57 UTC
(In reply to Yousuf Philips (jay) (retired) from comment #0)
> 3. move cursor to the beginning of the '(1)' line and notice the font hasnt
> changed instead of being Helvetica

What I see in 3.3.0 is that the font stays Helvetica.
In latest master, it changes to FreeSans.

Arch Linux 64-bit
Version: 6.3.0.0.alpha0+
Build ID: 2c7b0030b40de00e8c9ab997bdfe83631861968a
CPU threads: 8; OS: Linux 4.20; UI render: default; VCL: gtk3; 
Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US
Calc: threaded
Built on 1 January 2019
Comment 4 QA Administrators 2021-01-04 04:05:17 UTC Comment hidden (obsolete)
Comment 5 Aron Budea 2021-03-03 07:00:23 UTC
(In reply to Buovjaga from comment #2)
> So the target of the bibisectRequest was apparently about the Helvetica
> change. In 43all repo with Ubuntu 14.04, the font just stays Helvetica
> everywhere.

I thought it was the main, RTL font name change.
The text disappeared in 3.5.0 (already incorrect in earliest of bibisect-43all, thus setting preBibisect), and came back in 4.1, with the following commit, found using bibisect-41max:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=4a816a816e8b4e213394898bd0e307dd90fcbb64
author		Miklos Vajna <vmiklos@suse.cz>	2013-05-15 09:59:18 +0200
committer	Miklos Vajna <vmiklos@suse.cz>	2013-05-15 10:30:37 +0200

"fdo#62977 allow SAL_MAX_INT16..SAL_MAX_UINT16 when importing RTF_U"

The name of the Helvetica font for the LTR parts of the text (numbering, colons) changes to the default CTL font name with the following commit. An issue this commit corrected is that previously the numbering that should've been on the right was on the left (this had also been fine before 3.5.0, and regressed in that version).

https://cgit.freedesktop.org/libreoffice/core/commit/?id=4ee2a882dddb395a816cd54004b634d57cfb2446
author		Miklos Vajna <vmiklos@collabora.co.uk>	2015-04-17 10:44:47 +0200
committer	Miklos Vajna <vmiklos@collabora.co.uk>	2015-04-17 11:35:27 +0200

"tdf#86182 RTF import: fix handling of \rtlpar"