Bug 113185 - lang-pack on macOS lacks correct version identifier
Summary: lang-pack on macOS lacks correct version identifier
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Installation (show other bugs)
Version:
(earliest affected)
5.4.2.2 release
Hardware: All macOS (All)
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Language-Help-Packs
  Show dependency treegraph
 
Reported: 2017-10-17 14:16 UTC by Michal Moravec
Modified: 2024-07-05 23:10 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Moravec 2017-10-17 14:16:17 UTC
Current langpack installation method on macOS uses .app bundle with AppleScript.
Currently .app lacks any kind of version information in Info.plist.

I propose `CFBundleShortVersionString` and `CFBundleVersion` Info.plist keys of "LibreOffice Language Pack.app" are set to same version as corresponding `CFBundleShortVersionString` and `CFBundleVersion` of LibreOffice.app Info.plist.

This change would not affect user but it would help Mac admins who deploy LibreOffice and repackage language packs.
Comment 1 Alex Thurgood 2017-10-17 15:01:19 UTC
Confirming.

Currently, there is a value for CFBundleShortVersionString, but it seems to bear no relation to the LO app bundle version.

There doesn't appear to be any CFBundleVersion in the info.plist file in the fr-FR langpack that I can see, so I imagine that that would need to be added somehow.
Comment 2 Michal Moravec 2018-04-09 13:48:38 UTC
This should be simple fix but nothing have been done in one year. 
What could I do to help?
Comment 3 Xisco Faulí 2018-04-10 18:10:10 UTC
(In reply to Michal Moravec from comment #2)
> This should be simple fix but nothing have been done in one year. 
> What could I do to help?

Hi Michal,
Glad to hear you want to help.
Here you can see how to build LibreOffice for mac -> https://wiki.documentfoundation.org/Development/BuildingOnMac
then you just need to create the patch and submit it to gerrit as explained here:
https://wiki.documentfoundation.org/Development/gerrit
For help, you can use the dev IRC channel: https://irc.documentfoundation.org/?settings=#libreoffice-dev
I hope it helps...