Bug 113212 - Conditional Format sets format without condition checking
Summary: Conditional Format sets format without condition checking
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
5.3.5.2 release
Hardware: x86-64 (AMD64) All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, regression
Depends on:
Blocks: Conditional-Formatting
  Show dependency treegraph
 
Reported: 2017-10-18 04:54 UTC by Uwe
Modified: 2018-12-03 15:52 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Uwe 2017-10-18 04:54:19 UTC
Description:
Scenario:
Select a column,
Open configional format from main menu,
create a new conditional format 
Contition: value is equal to blue,
select or create a new format with blue background
click OK

Result:
The whole row is formatted with the selected format without evaluating the 
condition.


Steps to Reproduce:
Select a column,
Open configional format from main menu,
create a new conditional format 
Contition: value is equal to blue,
select or create a new format with blue background
click OK


Actual Results:  

Result:
The whole row is formatted with the selected format without evaluating the 
condition.

Expected Results:
The format shall only apply if the condition is met.


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0
Comment 1 raal 2017-10-18 16:35:41 UTC
$ git bisect log
# bad: [489ffd1df414698b6cea9ab03bf6f663b8b5af7e] source-hash-3f94c9e9ddfd807b449f3bb9b232cf2041fa12d2
# good: [8aa9fc9a0c92172593d6cd97662116a965db229d] source-hash-dea4a3b9d7182700abeb4dc756a24a9e8dea8474
git bisect start 'latest' 'oldest'
# bad: [897913acd244cb6a5d2f4c2da1d625d9b978edb6] source-hash-ac57362b23859591c088e36b7218f4a606dcf3bb
git bisect bad 897913acd244cb6a5d2f4c2da1d625d9b978edb6
# bad: [dc97f44745f96315fb6c5480705bb5d595d39c6c] source-hash-01c8962f281887db59e581906b89d027a994b52a
git bisect bad dc97f44745f96315fb6c5480705bb5d595d39c6c
# bad: [a5a39af2ec486b10b26d6373f58a9b59142106c4] source-hash-a595879302e26a616131aa0cab5de31bb287b37d
git bisect bad a5a39af2ec486b10b26d6373f58a9b59142106c4
# bad: [a5a39af2ec486b10b26d6373f58a9b59142106c4] source-hash-a595879302e26a616131aa0cab5de31bb287b37d
git bisect bad a5a39af2ec486b10b26d6373f58a9b59142106c4
# bad: [a5a39af2ec486b10b26d6373f58a9b59142106c4] source-hash-a595879302e26a616131aa0cab5de31bb287b37d
git bisect bad a5a39af2ec486b10b26d6373f58a9b59142106c4
# bad: [a5a39af2ec486b10b26d6373f58a9b59142106c4] source-hash-a595879302e26a616131aa0cab5de31bb287b37d
git bisect bad a5a39af2ec486b10b26d6373f58a9b59142106c4
# bad: [a5a39af2ec486b10b26d6373f58a9b59142106c4] source-hash-a595879302e26a616131aa0cab5de31bb287b37d
git bisect bad a5a39af2ec486b10b26d6373f58a9b59142106c4
# bad: [a5a39af2ec486b10b26d6373f58a9b59142106c4] source-hash-a595879302e26a616131aa0cab5de31bb287b37d
git bisect bad a5a39af2ec486b10b26d6373f58a9b59142106c4
# good: [f8e8e050f410de99f06c21879d7e4e21b31ea908] source-hash-22fd097f37b905cb3b585caf96890690befed863
git bisect good f8e8e050f410de99f06c21879d7e4e21b31ea908
# bad: [4d49ccb0cf0c0e1e3bfe9d3bc25baea143032488] source-hash-ad8aeb6e02444aa007ef38a59bbd84d67d60ffad
git bisect bad 4d49ccb0cf0c0e1e3bfe9d3bc25baea143032488
# good: [dca2502b5f4ac274e452cc768bffff76c491e1e7] source-hash-5419a2a8633c0f195a99cdc422e3e6c29bd8911f
git bisect good dca2502b5f4ac274e452cc768bffff76c491e1e7
# bad: [eb02dcbd65919e0bc21cd0cc3cb4f064c857b8bf] source-hash-4e3e1420af51f7776dceb6b2800b761e57ddfe63
git bisect bad eb02dcbd65919e0bc21cd0cc3cb4f064c857b8bf
# bad: [792083eebfb012a3fa799a74c427d45d81596ce3] source-hash-3a45897d301c2eb356ef57df0542726afeb8a4ae
git bisect bad 792083eebfb012a3fa799a74c427d45d81596ce3
# good: [98eb974a3dca3e502d75c20cbb739bc587ce0508] source-hash-19c0d7ba5f726c3ccfa7e7075f9e7a66b59cd6db
git bisect good 98eb974a3dca3e502d75c20cbb739bc587ce0508
# bad: [a1956ec699ec6b38885066171a6cf3b673e5c329] source-hash-05e2fd162ef86ebe4ea2a2a679cabeae33e844f0
git bisect bad a1956ec699ec6b38885066171a6cf3b673e5c329
# first bad commit: [a1956ec699ec6b38885066171a6cf3b673e5c329] source-hash-05e2fd162ef86ebe4ea2a2a679cabeae33e844f0

http://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=19c0d7ba5f726c3ccfa7e7075f9e7a66b59cd6db..05e2fd162ef86ebe4ea2a2a679cabeae33e844f0
Comment 2 QA Administrators 2018-10-19 02:50:38 UTC Comment hidden (obsolete)
Comment 3 Roman Kuznetsov 2018-12-02 22:43:36 UTC
still repro in 

Version: 6.3.0.0.alpha0+
Build ID: 878c36f829fd88cda95ca218a2cf03003f50e53d
CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-11-24_22:47:49
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded

but I see warning in dialogue when I write word blue in field without quotes:

-> Strings without qoutes are interpreted as column/row labels <-.

may be it's expected behaviour now?
Comment 4 Xavier Van Wijmeersch 2018-12-03 15:23:46 UTC
Its working in all those versions
And yes the qoutes are needed, that's why when the qoutes are not used the word is always with a Yellow background and the warning is displayed
So for me its working, WMF

Version: 5.2.7.2
Build ID: 2b7f1e640c46ceb28adf43ee075a6e8b8439ed10
CPU Threads: 8; OS Version: Linux 4.19; UI Render: default; VCL: kde4; 
Locale: nl-BE (en_US.UTF-8); Calc: group

Version: 5.3.8.0.0+
Build ID: 3d5aba02a6fc3ce118c8eb31e3b2ec7794d48533
CPU Threads: 8; OS Version: Linux 4.19; UI Render: default; VCL: kde4; Layout Engine: new; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:libreoffice-5-3, Time: 2018-04-18_11:23:40
Locale: nl-BE (en_US.UTF-8); Calc: group

Version: 6.3.0.0.alpha0+
Build ID: 4da61d4cc8f70ff62d7bac23a1b97d9d7011a678
CPU threads: 8; OS: Linux 4.19; UI render: default; VCL: kde4; 
Locale: nl-BE (en_US.UTF-8); UI-Language: en-US
Calc: threaded
Comment 5 Buovjaga 2018-12-03 15:52:59 UTC
Ok, let's close.