Bug 113310 - Special characters: A favorite character is only added to recent, if you insert it from the special characters dialog
Summary: Special characters: A favorite character is only added to recent, if you inse...
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha0+
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsUXEval
Depends on:
Blocks: Special-Character
  Show dependency treegraph
 
Reported: 2017-10-20 19:41 UTC by Mirosław Zalewski
Modified: 2021-10-14 12:26 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mirosław Zalewski 2017-10-20 19:41:28 UTC
Description:
When inserting special characters, one can click on character from list of Favorites. When this is done on small box that appear after clicking icon, that character will not be added to list of favorites. When this is done on dialog window (after clicking "Launch dialog"), that character will be added to list of favorites.

I don't have strong opinion on which is more correct (both behaviors are justifiable), but I do expect consistent behavior of one function accessed from two different places.

Steps to Reproduce:
1. Open Writer
2. Click "Insert Special Characters" icon
3. Click any character from Favorites list
4. Notice that this character was inserted, but if you click on "Insert Special Characters" icon, it won't be on list of recent characters
5. Click "Insert Special Characters" icon again
6. Click "Launch dialog"
7. Click on any character from Favorites list
8. Click "Insert"
9. click on "Insert Special Characters" icon and notice that this time, it was added to list of recent characters

Actual Results:  
Behavior is not consistent

Expected Results:
Behavior is consistent - either character is added to list of recent characters in both cases, or in neither case


Reproducible: Always

User Profile Reset: Yes

Additional Info:
Version: 6.0.0.0.alpha1
Build ID: c1d1f859b268f650143d48f294999cda0fa57350
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: kde4; 
Locale: pl-PL (pl_PL.UTF-8); Calc: group

This is daily build of LO 6.0 from October 20th 2017.


User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36
Comment 1 Dieter 2017-10-21 08:07:12 UTC
I tried to reproduce it.

Result: A special character is only added to recent characters if you added it via (launch dialog). If you use favourites, they are not added to recent characters => I confirm your steps 1-4, but not 5-9. I don't think, that this is a bug. Pershaps it could be useful to rename ("recent characters" in "recent characters (without favourites)" to make it more clear)

Version: 6.0.0.0.alpha1 (x64)
Build ID: c1d1f859b268f650143d48f294999cda0fa57350
CPU threads: 4; OS: Windows 10.0; UI render: default; 
Locale: de-DE (de_DE); Calc: group
Comment 2 Mirosław Zalewski 2017-10-21 15:39:05 UTC
Dieter,

From your message it seems to me that you have reproduced entire issue, so I am not sure how you reach your conclusion.

Maybe I'll try to put it this way:

1. Start with empty "Recent characters" list
2. Click "Insert special characters" icon
3. Click any character on "Favorites" list on little pop-up that appeared
4. Click "Insert special characters" icon again
5. Click "Launch dialog"
6. Click any character on "Favorites" list on bottom of window that appeared - be sure to select different character than in step 3. Click "Insert" and close that window
7. Click "Insert special characters" icon and observe "Recent characters" list

At this point, "Recent characters" list will contain ONE character. You have added character from "Favorites" list twice, but only once it was registered on "Recent characters" list (after step 6).

This is internal application inconsistency. Users see these actions as equivalent (this is the same data used for the same purpose, only exposed in two different windows) and can expect to achieve exactly the same results in both cases. But currently, they do not.

So, this is a bug and should be changed. 

As I have noted, I do not have strong opinion if inserting character from "Favorites" list should result in that character being added to "Recent characters" list, or not. Just do the same thing regardless on which window was used.
Comment 3 Dieter 2017-10-22 12:44:36 UTC
Miroslaw, you're right. I haven't read your step 7 carefully enough and so I added any special character (but not from the favourite list).

So I confirm your bug.
Comment 4 QA Administrators 2018-10-23 02:48:55 UTC Comment hidden (obsolete)
Comment 5 Dieter 2018-10-23 07:36:06 UTC
Still reproducible with

Version: 6.2.0.0.alpha1+ (x64)
Build ID: 8274c4c62df5b937b3f0bec9e1eeca85f3b219d4
CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-10-22_01:47:50
Locale: en-US (de_DE); Calc: CL
Comment 6 Heiko Tietze 2018-11-12 09:18:33 UTC
The recently used characters should not be filled with items from the favorites section. There are three ways to, for example, add the omega symbol:

a) Floating widget: not added
b) Dialog with double click on the item: not added
c) Dialog using the Insert button: item is added to recently used regardless it's on the favorite list or not
Comment 7 QA Administrators 2019-11-13 03:33:56 UTC Comment hidden (obsolete)
Comment 8 Dieter 2021-10-07 07:44:54 UTC
Still same behaviour in

Version: 7.2.1.2 (x64) / LibreOffice Community
Build ID: 87b77fad49947c1441b67c559c339af8f3517e22
CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

Heiko I can understand the idea that is behind your comment 6, but this is counterintuitive, because "Recently used" is very clear most of the users will expect recently used characters from list of Favourites here. So I would say we should

a) Follow this bug report and add characters from favourite list to "Recently used"
b) Follow you suggestion, but then change expression to "Other recently used" or "Recently used non-favourites"(or something like that)

=> Design-Team for decision
Comment 9 Heiko Tietze 2021-10-07 08:44:44 UTC
Dieter probably asks UX whether Favorites should be added to the list of Recently Used characters. To repeat what I said in comment 6, the current state is:

* click on favorites in the floating widget: not added
* double-click on favorites in dialog (followed by cancel): not added

* single-click on favorites in the dialog and confirming per Insert: added
* single-click on any character in the dialog and confirming per Insert: added
* double-click on any character in the dialog: added

Arguments to always update the recent characters:
* consistency
and against:
* the list of recently used is filled with duplicates from favorites
* the list is shuffled a lot
Comment 10 V Stuart Foote 2021-10-07 11:56:43 UTC
(In reply to Heiko Tietze from comment #9)
> Dieter probably asks UX whether Favorites should be added to the list of
> Recently Used characters.

No duplicates--because the favorites and recents lists are both always visible and the two lists are too short already for many locales (bug 120753).

The list of 'Favorites', which can be directly modified by user, is implemented as a stack preloaded with localized defaults. The 'Recently used' is dynamic, its stack expands to its maximum (currently 16). As both stacks are listed together for the SCD split button--items on favorites should not be duplicated onto the recents.

The behavior of the split button to *not add* a pick from recents list to favorites list is the better behavior.  

Behavior of the two lists on the Special Character dialog is what is not consistent--and IMHO wrong.

For consistency *any* pick already on the favorites stack--from the dialog char chart or the favorites list--should not be pushed onto the recents stack (the two stacks would need to be logically linked and favorites checked to avoid the duplication onto recents).
Comment 11 V Stuart Foote 2021-10-07 12:07:40 UTC
(In reply to V Stuart Foote from comment #10)
> ... preloaded with localized defaults.

Oops, not yet for localized defaults, that's still open as bug 120899 --either from CLDR or by i18n action
Comment 12 Heiko Tietze 2021-10-14 12:26:26 UTC
The topic was on the agenda of the design meeting but hasn't received further input. So let's resolve NAB since we don't want to duplicate.