Bug 113343 - Special character: context menu has no function
Summary: Special character: context menu has no function
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Heiko Tietze
URL:
Whiteboard: target:6.1.0 target:6.0.0.1
Keywords:
Depends on:
Blocks: Special-Character
  Show dependency treegraph
 
Reported: 2017-10-22 12:43 UTC by Dieter
Modified: 2019-09-23 19:47 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of the issue (9.86 KB, image/png)
2017-10-23 07:15 UTC, Heiko Tietze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dieter 2017-10-22 12:43:44 UTC
Steps to reproduce:

1. Open a writer document
2. Click "insert special character" icon
3. Open context menu
4. You can click "remove" or "clear them all", but nothing happens
Comment 1 Xisco Faulí 2017-10-22 22:39:08 UTC
Confirmed in

Version: 6.0.0.0.alpha1+
Build ID: 118a0a3734a3f794c67a9d7d4376d8ed78a96fee
CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group
Comment 2 Heiko Tietze 2017-10-23 07:15:06 UTC
Created attachment 137226 [details]
Screenshot of the issue

Context menu on a floating widget makes no sense. Just remove it.
Comment 3 Heiko Tietze 2017-11-29 10:13:09 UTC
Patch submitted https://gerrit.libreoffice.org/#/c/45475/
Comment 4 Commit Notification 2017-12-06 15:48:21 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2246ab1a187a5ca73b35ca700c1db63c9b74054e

tdf#113343 Floating charmap window must not have a context menu

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Heiko Tietze 2017-12-06 17:58:47 UTC
/done
Comment 6 Commit Notification 2017-12-06 17:59:13 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "libreoffice-6-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=7a0fefa3818e9218f3f871ce3156df39ee444703&h=libreoffice-6-0

tdf#113343 Floating charmap window must not have a context menu

It will be available in 6.0.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Jim Raykowski 2017-12-17 23:12:21 UTC
Hi All,

I noticed when helping out on this one the special character that is highlighted in the context menu can be inserted multiple times by using the enter key. This seems like a nice "feature". As it is now only the first special character in the context menu has this "feature". Maybe it would be worthwhile to have right click change the highlighted special character to allow it to be inserted multiple times with the enter key?
Comment 8 Dieter 2017-12-18 07:21:58 UTC
Good idea, but I'd like to suggest to use the arrow-keys to change the highlighted special character.

But I think this is an proposal for an enhancement, so it's better to open a new bug report?
Comment 9 Heiko Tietze 2017-12-18 08:43:17 UTC
Akshay implemented keyboard accessibility in the dialog with cursor keys to navigate and enter to insert. Would a user expect such thing in a floating context menu that opens per click only? Guess not, and putting much effort in this seems a waste of time. Additionally to the arrow keys you need feedback where the focus is  (could be weird when this highlighting happens on click before insert and close). So disabling this easter egg seems to be the better choice to me.
Comment 10 Maxim Monastirsky 2017-12-18 09:19:32 UTC
(In reply to Heiko Tietze from comment #9)
> Akshay implemented keyboard accessibility in the dialog with cursor keys to
> navigate and enter to insert. Would a user expect such thing in a floating
> context menu that opens per click only? Guess not, and putting much effort
> in this seems a waste of time.
But we do provide a way to use toolbars w/o a mouse, via pressing F6 until the focus lands on the needed toolbar, then navigate using the arrow keys to the button, and pressing the down or up key to open the dropdown menu. So it will be useful to have that dropdown menu work with the keyboard. Although I don't think it should allow inserting multiple times, but rather close the dropdown menu after the first time, similar to a mouse click.

> Additionally to the arrow keys you need
> feedback where the focus is  (could be weird when this highlighting happens
> on click before insert and close).
Right, so the highlighting should be visible only in case the dropdown menu was opened using the keyboard, or if an arrow key was pressed at least once. We have similar behavior in the "Borders" button of the Table toolbar, and I think we should have the same behavior here.
Comment 11 Dieter 2019-09-23 19:47:22 UTC
No context menu in

Version: 6.3.2.2 (x64)
Build-ID: 98b30e735bda24bc04ab42594c85f7fd8be07b9c
CPU-Threads: 4; BS: Windows 10.0; UI-Render: GL; VCL: win; 
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
Calc: threaded

=> VERIFIED FIXED