Bug 113478 - Rename 'Decimal separator key' to 'Numpad decimal key'
Summary: Rename 'Decimal separator key' to 'Numpad decimal key'
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Samuel Adesola
URL:
Whiteboard: target:24.2.0 inReleaseNotes:24.2
Keywords: difficultyBeginner, easyHack, skillDesign, topicUI
Depends on:
Blocks: Decimal-Separator-Key
  Show dependency treegraph
 
Reported: 2017-10-27 09:08 UTC by Yousuf Philips (jay) (retired)
Modified: 2024-01-26 09:57 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2017-10-27 09:08:42 UTC
After looking at the help about this setting, it was quite clear what it was, but reading the label wasnt clear, so i think it should be renamed for clarity.

https://help.libreoffice.org/Common/Languages#Decimal_separator_key_-_Same_as_locale_setting

Heiko, Stuart, Adolfo: thoughts?
Comment 1 Heiko Tietze 2017-10-27 09:54:25 UTC
Thought 'decimal separator' would be the standard but apparently it's a standalone feature that the numpad separator can be tweaked separately. So +1 to the change.
Comment 2 Jeff Fortin Tam 2023-02-10 03:48:20 UTC
+1, I was highly confused by this while trying to use this piece of UI tonight and not seeing any effect, until I found this bug report that revealed it only controls the behavior of the numpad.

Surely this would be a trivial change (it's just a label to change, isn't it?), so I'm taking the liberty of tagging this "EasyHack"...
Comment 3 Heiko Tietze 2023-02-14 10:06:56 UTC
Latest help says:

Decimal separator key - Same as locale setting
Specifies to use the decimal separator key that is set in your system when you press the respective key on the number pad.

If this checkbox is activated, the character shown after "Same as locale setting" is inserted when you press the key on the number pad. If this checkbox is not activated, the character that your keyboard driver software provides is inserted.

https://help.libreoffice.org/latest/en-US/text/shared/optionen/01140000.html?DbPAR=SHARED#bm_id3154751

On a German keyboard the numpad separator key is a comma and I can make it insert a dot with this option. Although the function still inserts a decimal separator it wont hurt to name it "Numpad decimal separator" (or key; we should keep it short).

Code pointer:
cui/uiconfig/ui/optlanguagespage.ui
Comment 4 Commit Notification 2023-07-06 14:29:20 UTC
Adoche Onaji committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3d2f9b63e61a32ff07d850103f059dda88b56d6e

tdf#113478 'Decimal separator key' property was renamed to 'Numpad decimal key'

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.