Bug 113500 - AutoFill with combined cell content incorrectly increments value when starting from the same content
Summary: AutoFill with combined cell content incorrectly increments value when startin...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
3.6.0.4 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.1.0
Keywords: bibisected, regression
Depends on:
Blocks: AutoFill
  Show dependency treegraph
 
Reported: 2017-10-28 18:33 UTC by Aron Budea
Modified: 2021-01-07 08:33 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aron Budea 2017-10-28 18:33:20 UTC
Type the following text in cells A1 & A2: A1
Select both, and fill the cells down using the autofill handle.

=> result is:
A1
A1
A2
A2
A3
A3
etc.

While if you do the same with the number 1, then the entries correctly stay the same when filled down.

Observed with LO 5.4.2.2 & 3.6.0.4 / Windows 7.
Works fine with LO 3.5.0.3.
=> regression, probably can't be bibisected, but could be verified with the oldest state of bibisect-43all

Bug 89754 is the same with dates, but that is not a regression.
Comment 1 Jacques Guilleron 2017-10-28 22:40:48 UTC
Hi Aron,

I reproduce with
LO 5.4.2.2 Build ID: 22b09f6418e8c2d508a9eaf86b2399209b0990f4
Threads CPU : 2; OS : Windows 6.1; UI Render : par défaut; 
Locale : fr-FR (fr_FR); Calc: CL
also with
LO 3.6.1.2 (Build ID: e29a214)
but not with
LO  3.5.3.2 Version ID : 235ab8a-3802056-4a8fed3-2d66ea8-e241b80
With the same text in the two first cells, selecting A1:A10, Ctrl+D fills the cells with A1 text into the same LO versions.
Comment 3 Aron Budea 2018-06-20 17:58:56 UTC
Probably from this commit:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=5af699cf62b2313980add377a777c49dc1e7ae2a
author		Markus Mohrhard <markus.mohrhard@googlemail.com>	2012-04-15 00:11:08 +0200
committer	Markus Mohrhard <markus.mohrhard@googlemail.com>	2012-04-15 01:26:03 +0200

don't deduce increment from multiple equal list entries, fdo#39500
Comment 4 QA Administrators 2019-06-21 02:52:47 UTC Comment hidden (obsolete)
Comment 5 NISZ LibreOffice Team 2020-10-21 09:28:19 UTC
0 increment is still considered as 1 in todays nightly:

Version: 7.1.0.0.alpha0+ (x64)
Build ID: e0c72e31c1d455c26110c35e8780d420e17cdea6
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: CL
Comment 6 Commit Notification 2020-11-17 11:24:20 UTC
Attila Szűcs committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4bcfa22a66deef210535391cfc3f683851b1b3f7

tdf#113500 sc: fix autofill of same mixed values

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 NISZ LibreOffice Team 2021-01-07 08:33:30 UTC
Verified in:

Version: 7.2.0.0.alpha0+ (x64)
Build ID: 96bafa464ebdbce3ef04bec9beae5e745bb37794
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: threaded

Thanks for fixing!