Bug 113527 - UI Cannot cancel customize action on toolbar
Summary: UI Cannot cancel customize action on toolbar
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
5.2.7.2 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Customize-Dialog
  Show dependency treegraph
 
Reported: 2017-10-30 16:33 UTC by Emil Tanev
Modified: 2019-03-10 17:18 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Emil Tanev 2017-10-30 16:33:26 UTC
Open View > Toolbars > Customize
Check a couple of unchecked icons in the Toolbars dialog
(I checked mail and edit mode)
Notice how they appear in the toolbar immediately
Click Cancel

Issue: The icons remain, i.e. they are not cancelled.

https://www.screencast.com/t/yTIHnttVC98


Version: 6.0.0.0.alpha1+ (x64)
Build ID: d30522e46ca884e9bc74af21711d9537e8118859
CPU threads: 8; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2017-10-30_00:25:37
Locale: ja-JP (ja_JP); Calc: CL
Comment 1 Kevin Suo 2017-11-03 09:03:28 UTC
Confirmed in:

Version: 6.0.0.0.alpha1+
Build ID: 2416d69ad4fa26b65d5b05a8575ac96af6b2c9a9
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; 
Locale: zh-CN (zh_CN.UTF-8); Calc: group

Version: 5.5.0.0.alpha0+
Build ID: b5d72331053ce19942463ac6e688eac74e01e649
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; 
Locale: zh-CN (zh_CN.UTF-8); Calc: group

Set to NEW.

This bug behaviour also exists in Writer (and maybe other modules).
Comment 2 Muhammet Kara 2018-03-09 18:55:11 UTC
This bug is not specific to Writer.

By the first look at the related code, I can tell that it is because of the way how customize dialog's toolbar operations are implemented. (A conscious decision, but I can't tell the reason right away.)

Anyway, I think this should be fixed to have a consistent behavior through all tabs. (Otherwise, having a Cancel button would be nonsense.)
Comment 3 QA Administrators 2019-03-10 03:21:50 UTC Comment hidden (obsolete)
Comment 4 Roman Kuznetsov 2019-03-10 17:11:05 UTC
Muhammet, any news about this from you?=)
Comment 5 Muhammet Kara 2019-03-10 17:18:40 UTC
(In reply to Roman Kuznetsov from comment #4)
> Muhammet, any news about this from you?=)

Nope. Looked into it at some point and started to write something, but it is long gone now. If anyone is interested in fixing this, it is still there & doable. One can take a look at the implementation of the Menus tab, to have an idea on how to fix it. (Menu tab works correctly.)

So I confirm that this is still a valid bug report as of 9e88a5cd5332944bc643534cacaf7cfceaad11e6