Bug 113544 - FILEOPEN: RTF - Spacing above paragraph not retained
Summary: FILEOPEN: RTF - Spacing above paragraph not retained
Status: RESOLVED DUPLICATE of bug 113408
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
(earliest affected) rc
Hardware: All All
: medium normal
Assignee: Miklos Vajna
Keywords: bibisected, bisected, regression
Depends on:
Blocks: RTF-Paragraph
  Show dependency treegraph
Reported: 2017-10-31 06:04 UTC by Yousuf Philips (jay) (retired)
Modified: 2017-11-16 21:53 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

sample (1.15 MB, text/rtf)
2017-10-31 06:24 UTC, Yousuf Philips (jay) (retired)

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2017-10-31 06:04:59 UTC
Bug 82074 has resurfaced again as a regression in 5.3.x

1. open attachment
2. notice there is no space above the word 'Security'

Build ID: 60a03d97bc35c02cb1eff0e4a02b6f37fd1a6a34
CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk2; 
Locale: en-US (en_US.UTF-8); Calc: group
Comment 1 Yousuf Philips (jay) (retired) 2017-10-31 06:24:35 UTC
Created attachment 137391 [details]
Comment 2 Xisco Faulí 2017-10-31 06:38:59 UTC
Regression introduced by:

author	Miklos Vajna <vmiklos@collabora.co.uk>	2017-01-03 07:49:43 (GMT)
committer	Miklos Vajna <vmiklos@collabora.co.uk>	2017-01-03 10:56:29 (GMT)
commit a9e029ace41562e28e9242d63230ad1ca275f5d3 (patch)
tree 605fee980e467c8a5896bdf5053fd7422865091a
parent c9c5c94771f22919ec82351b3b9b3096af96a508 (diff)
tdf#104744 RTF import: fix unexpected zero para left margin wrt style dedup
See commit 1be0a3fa9ebb22b607c54b47739d4467acfed259 (n#825305:
writerfilter RTF import: override style properties like Word,
2014-06-17) for the details on style override in RTF.

Here the problem was that we added an unneeded "reset to 0" property, the
opposite situation that commit 657c6cc3acec0528209a8584b838cd6de581c437
(tdf#104228 RTF import: fix override of style left/right para margin,
2016-12-13) was fixing (there a "reset to 0" was missing).

Bisected with: bibisect-linux-64-5.4

Adding Cc: to Miklos Vajna
Comment 3 Miklos Vajna 2017-11-16 21:53:41 UTC
This works for me on master, reverse bisect points out commit 1970a686273c5d4fc1eeb4430283e37085d9f647 (tdf#113408 RTF import style dedup: separate paragraph and character handling, 2017-10-31). Closing as a duplicate of bug 113408.

*** This bug has been marked as a duplicate of bug 113408 ***