Bug 113621 - FILESAVE XLSX Conditional formatting range is lost if it is applied to a whole column
Summary: FILESAVE XLSX Conditional formatting range is lost if it is applied to a whol...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.1.0.4 release
Hardware: All All
: medium normal
Assignee: Markus Mohrhard
URL:
Whiteboard: target:6.1.0 target:6.0.0.1 target:7.0.0
Keywords: filter:xlsx
Depends on:
Blocks:
 
Reported: 2017-11-03 11:13 UTC by Gabor Kelemen (allotropia)
Modified: 2020-04-13 12:29 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file from Excel 2013 (13.88 KB, application/vnd.openxmlformats-officedocument.spreadsheetml.sheet)
2017-11-03 11:13 UTC, Gabor Kelemen (allotropia)
Details
Example file saved from 6.0 alpha (12.26 KB, application/vnd.openxmlformats-officedocument.spreadsheetml.sheet)
2017-11-03 11:15 UTC, Gabor Kelemen (allotropia)
Details
Screenshot of the document in LO and Excel 2013 (110.45 KB, image/png)
2017-11-03 11:15 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2017-11-03 11:13:21 UTC
Created attachment 137501 [details]
Example file from Excel 2013

The range of a conditional formatting applied to a whole column in Excel 2013 is lost when the XLSX file is opened in LibreOffice Calc and saved as XLSX.

Steps to reproduce:
1. Create a new spreadsheet in Excel 2013.
2. Select a whole column and apply a conditional formatting rule to it.
3. Save the file as XLSX and close Excel.
4. Open the file in LibreOffice Calc and save it as XLSX.
5. Reload the file.

Actual results:
While the rule for the conditional still exists, the range is lost, and therefore it isn't applied anymore.

Expected results:
The conditional formatting rule and range should be fully preserved.
Comment 1 Gabor Kelemen (allotropia) 2017-11-03 11:15:19 UTC
Created attachment 137502 [details]
Example file saved from 6.0 alpha
Comment 2 Gabor Kelemen (allotropia) 2017-11-03 11:15:58 UTC
Created attachment 137503 [details]
Screenshot of the document in LO and Excel 2013
Comment 3 raal 2017-11-03 15:59:57 UTC
I can confirm with LO 6 and LO 4.1, Linux
Comment 4 Markus Mohrhard 2017-12-14 22:52:46 UTC
Simple problem with the ScRangeLissssst::Format method not having  an option to differentiate between full address mode and the new full row/column addresses.
Comment 5 Commit Notification 2017-12-15 03:32:58 UTC
Markus Mohrhard committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2194105a38631e1c5c074634bc5b084cd2f8661f

tdf#113621: don't write whole column refs for conditional format ranges

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2017-12-15 13:11:12 UTC
Markus Mohrhard committed a patch related to this issue.
It has been pushed to "libreoffice-6-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=9e0ab4e19dc47953fe5ddff4b0af83b652d4f09b&h=libreoffice-6-0

tdf#113621: don't write whole column refs for conditional format ranges

It will be available in 6.0.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2020-04-13 12:29:42 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5f8d60cde34302531642e75ed93e9621e170982a

tdf#113621: Add unittest

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.