Bug 113633 - Turn hidden buttons to visible toggle buttons in line spacing group button
Summary: Turn hidden buttons to visible toggle buttons in line spacing group button
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha1+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Split-Group-Buttons-Line-Spacing
  Show dependency treegraph
 
Reported: 2017-11-03 18:46 UTC by Yousuf Philips (jay) (retired)
Modified: 2018-01-31 11:45 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2017-11-03 18:46:19 UTC
When you open the line spacing group button, you cant easily see what the current line spacing is because the buttons are not toggle buttons and the button outlines only appear when you mouse over the buttons.
Comment 1 Heiko Tietze 2017-11-03 20:59:30 UTC
Menus are not toggle buttons so there wont get a lowered appearance, I guess. But some kind of indicator is definitely needed. And that could be done with a dashed rectangle or a highlighted background, like in other menus buttons.

Workaround today: get the information from the custom value field.
Comment 2 Yousuf Philips (jay) (retired) 2017-11-05 15:33:58 UTC
(In reply to Heiko Tietze from comment #1)
> Menus are not toggle buttons so there wont get a lowered appearance, I
> guess.

It isnt a menu, its a canvas that glade ui elements are being placed on.

> But some kind of indicator is definitely needed. And that could be
> done with a dashed rectangle or a highlighted background, like in other
> menus buttons.

I've been thinking and it would be better to have the button replaced with checkboxes.

> Workaround today: get the information from the custom value field.

Now that Jim is adding the 2.5 and 3.0 line spacing to the canvas, we can get rid of this and have a more options button, for those who want advanced access.
Comment 3 Maxim Monastirsky 2018-01-31 11:45:04 UTC
I would prefer menu items instead, as that's a standard approach in the UI for presenting a list of options, and they can easily have check marks and/or icons. And that will add more consistency, as we already have other menu based toolbar popups. (For comparison, Word also uses a menu for this).

But using a standard menu will make it impossible to continue offering the custom value field. One option is to get rid of it, in favor of a "More" item (like suggested in comment 2). Another option is to not use a standard menu, but some other menu-like widget, which can also host a custom controls inside. One such control is the one we use for several popups like bullets, new slide, or the various popups of the 3D-Settings and Fontwork toolbars. Another possibility is the control used for the auto filter dropdown in Calc.