Bug 113646 - Font size in conditional style not saved with round trip xlsx
Summary: Font size in conditional style not saved with round trip xlsx
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: high normal
Assignee: Markus Mohrhard
URL:
Whiteboard: target:6.2.0 target:6.1.0.2 target:7.2.0
Keywords: dataLoss, filter:xlsx
Depends on:
Blocks: XLSX-Conditional-Formatting
  Show dependency treegraph
 
Reported: 2017-11-04 13:23 UTC by Affe
Modified: 2021-06-02 13:07 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Example ODS to be saved as XLSX (8.07 KB, application/vnd.oasis.opendocument.spreadsheet)
2017-11-11 17:03 UTC, Buovjaga
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Affe 2017-11-04 13:23:48 UTC
Description:
In Calc, with a column of ranked numbers like 23,15,6,3,11,43,25,7, and so on.
The intention is to make rank 1 to 10 more noticeable, by setting the numbers a bigger font, using conditional format.
When the format was set it was all good.
When the file is saved, closed and opened again, the font size from the conditional format is lost.



Steps to Reproduce:
1.Generate a column of numbers
2.Set conditional format: numbers <10 a bigger size of font
3.Save the file, close it.
4.Open it again, see the bigger fonts disappear.

Actual Results:  
Fonts are of a uniformed size.

Expected Results:
Bigger fonts shall be like before file is closed.


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Version: 5.4.2.2 (x64)
Build ID: 22b09f6418e8c2d508a9eaf86b2399209b0990f4
CPU threads: 16; OS: Windows 6.1; UI render: GL; 
Locale: en-GB (en_GB); Calc: group

Disabling OpenGL doesn't make difference.


User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0
Comment 1 Affe 2017-11-04 13:27:56 UTC
This happens with file saved in .xlsx format.
But not in .ods format.
Comment 2 Buovjaga 2017-11-11 17:03:02 UTC
Created attachment 137683 [details]
Example ODS to be saved as XLSX

Repro.

Arch Linux 64-bit, KDE Plasma 5
Version: 6.0.0.0.alpha1+
Build ID: 1aba1955f161cc112dab80b6b3e78ec7761616fc
CPU threads: 8; OS: Linux 4.13; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on November 10th 2017
Comment 3 Buovjaga 2017-11-11 17:04:50 UTC
Already in
Arch Linux 64-bit
LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4
Comment 4 Markus Mohrhard 2018-07-15 19:50:12 UTC
That was an oversight by me when I wrote the new dxf based conditional format XLSX export. Should be fixed now.
Comment 5 Markus Mohrhard 2018-07-15 22:47:58 UTC
I can't fix the attached document as that already contains some problematic content in the styles section due to another bug.

However after fixing the other bug any new document and any document that does not contains CJK and CTL without Latin font information in the default style should work now. Additionally, all conditional format styles that have an explicit font set should work all the time.
Comment 6 Commit Notification 2018-07-16 00:58:48 UTC
Markus Mohrhard committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=952cbfd2de0801081665a8ff05600eb7ea1cf82f

related tdf#113646, keep cjk, ctl font items in sync

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2018-07-16 16:01:15 UTC
Markus Mohrhard committed a patch related to this issue.
It has been pushed to "libreoffice-6-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=aa79f08a2ef5b9390b7e9ad91b3fe2da200bfe32&h=libreoffice-6-1

related tdf#113646, keep cjk, ctl font items in sync

It will be available in 6.1.0.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2018-07-16 19:37:51 UTC
Markus Mohrhard committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=14c2ca1b4efad2dcdc40e6d5c218cedd487857aa

tdf#113646, export font size for dxf records

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2018-07-17 09:49:25 UTC
Markus Mohrhard committed a patch related to this issue.
It has been pushed to "libreoffice-6-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=91eec155eb9433343c7e549907960855b6e91e7b&h=libreoffice-6-1

tdf#113646, export font size for dxf records

It will be available in 6.1.0.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Affe 2018-07-20 14:20:48 UTC
Hi, Mr. Mohrhard,

Thank you for making the fix!

I'm using Calc instead of Excel more and more often.

I will give 6.1.0.2 a try and see it works!

Thank you!

Best Regards,
Chen Haijun
Comment 11 Commit Notification 2021-06-02 13:07:22 UTC
Gizem Ozgun committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c10df6edb8a48b4a57f73ccb6155d051a8cfb5d0

tdf#113646 Add missing test for exporting conditional format font size.

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.