Open attachment 114686 [details] from bug 90511 with a debug build (asserts are only checked in debug builds). => Assertion failed. // ... if it isn't, this is a Bad Thing, assert and return the local name assert(false); https://opengrok.libreoffice.org/xref/core/xmloff/source/core/nmspmap.cxx#264 These are the parameters: nKey = 40 rLocalName = width bCache = true And indeed, there's no namespace entry with key 40 in the checked containers. I have a vague memory there was no assert 3 weeks ago, but can't say for sure. Observed using a fresh LO 6.0 master build (b56479e88edeabd6c6fe51cc0095a23543229856) / Windows 7.
And indeed, had a debug build lying around from October 6, where there is no assert (da82b030e8b10f4b0b79220bf32eadd8d022684e). => regression, notBibisectable (except maybe using Linux daily dbgutil repo, if it occurs on Linux)
No assert in Linux, so apparently this is Win-only, and thus not bibisectable (unless there is a noticeable bug with a non-debug build). Version: 6.0.0.0.alpha1+ Build ID: a3a917748892a6a3194ebfc4db64cfd764cc054a CPU threads: 16; OS: Linux 4.10; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); Calc: group
Ok, this is somewhat of a user error, but there's still an assert. In Options, Load/Save -> General -> 'ODF format version' has to be set to 1.2 for the assert to trigger.
Just for the record, under Fedora 26 with a dbgutil build I get the following in terminal: warn:sfx.control:18940:18940:sfx2/source/control/dispatch.cxx:1374: Childwindow slot missing: 25917 warn:sfx.control:18940:18940:sfx2/source/control/dispatch.cxx:1374: Childwindow slot missing: 25917 warn:sfx.control:18940:18940:sfx2/source/control/dispatch.cxx:1374: Childwindow slot missing: 25917 warn:legacy.tools:18940:18940:svx/source/form/fmvwimp.cxx:444: FmXFormView::~FmXFormView: Window list not empty! warn:chart2:18940:18940:chart2/source/tools/LifeTime.cxx:118: This component is already disposed warn:svl.items:18940:18940:svl/source/items/itempool.cxx:395: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty. warn:chart2:18940:18940:chart2/source/tools/LifeTime.cxx:118: This component is already disposed warn:svl.items:18940:18940:svl/source/items/itempool.cxx:395: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty. warn:legacy.osl:18940:18940:chart2/source/model/main/DataPoint.cxx:175: data point needs a parent property set to provide values correctly warn:legacy.osl:18940:18940:chart2/source/model/main/DataPoint.cxx:175: data point needs a parent property set to provide values correctly warn:legacy.osl:18940:18940:chart2/source/model/main/DataPoint.cxx:175: data point needs a parent property set to provide values correctly warn:legacy.osl:18940:18940:chart2/source/model/main/DataPoint.cxx:175: data point needs a parent property set to provide values correctly warn:legacy.osl:18940:18940:chart2/source/model/main/DataPoint.cxx:175: data point needs a parent property set to provide values correctly warn:legacy.osl:18940:18940:chart2/source/model/main/DataPoint.cxx:175: data point needs a parent property set to provide values correctly warn:legacy.osl:18940:18940:chart2/source/model/main/DataPoint.cxx:175: data point needs a parent property set to provide values correctly warn:legacy.osl:18940:18940:chart2/source/model/main/DataPoint.cxx:175: data point needs a parent property set to provide values correctly warn:legacy.osl:18940:18940:chart2/source/model/main/DataPoint.cxx:175: data point needs a parent property set to provide values correctly warn:legacy.osl:18940:18940:chart2/source/model/main/DataPoint.cxx:175: data point needs a parent property set to provide values correctly warn:legacy.osl:18940:18940:chart2/source/model/main/DataPoint.cxx:175: data point needs a parent property set to provide values correctly warn:legacy.osl:18940:18940:chart2/source/model/main/DataPoint.cxx:175: data point needs a parent property set to provide values correctly warn:legacy.osl:18940:18940:chart2/source/model/main/DataPoint.cxx:175: data point needs a parent property set to provide values correctly warn:legacy.osl:18940:18940:chart2/source/model/main/DataPoint.cxx:175: data point needs a parent property set to provide values correctly warn:legacy.osl:18940:18940:chart2/source/model/main/DataPoint.cxx:175: data point needs a parent property set to provide values correctly warn:legacy.osl:18940:18940:chart2/source/model/main/DataPoint.cxx:175: data point needs a parent property set to provide values correctly warn:legacy.osl:18940:18940:chart2/source/model/main/DataPoint.cxx:175: data point needs a parent property set to provide values correctly warn:legacy.osl:18940:18940:chart2/source/model/main/DataPoint.cxx:175: data point needs a parent property set to provide values correctly warn:legacy.osl:18940:18940:chart2/source/model/main/DataPoint.cxx:175: data point needs a parent property set to provide values correctly warn:legacy.osl:18940:18940:chart2/source/model/main/DataPoint.cxx:175: data point needs a parent property set to provide values correctly warn:chart2:18940:18940:chart2/source/tools/LifeTime.cxx:118: This component is already disposed warn:svl.items:18940:18940:svl/source/items/itempool.cxx:395: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty. warn:sfx.control:18940:18940:sfx2/source/control/dispatch.cxx:1374: Childwindow slot missing: 25917 warn:sfx.dialog:18940:18940:sfx2/source/dialog/filtergrouping.cxx:355: already have an element for WordPerfect warn:sfx.dialog:18940:18940:sfx2/source/dialog/filtergrouping.cxx:355: already have an element for writerweb8_writer_template warn:sfx.dialog:18940:18940:sfx2/source/dialog/filtergrouping.cxx:355: already have an element for writerglobal8 warn:oox:18940:18940:oox/source/docprop/docprophandler.cxx:321: OOXMLDocPropHandler::startFastElement: unknown element 5619 warn:oox:18940:18940:oox/source/docprop/docprophandler.cxx:321: OOXMLDocPropHandler::startFastElement: unknown element 3197 warn:oox:18940:18940:oox/source/docprop/docprophandler.cxx:321: OOXMLDocPropHandler::startFastElement: unknown element 5619 warn:oox:18940:18940:oox/source/docprop/docprophandler.cxx:321: OOXMLDocPropHandler::startFastElement: unknown element 2748 warn:oox:18940:18940:oox/source/docprop/docprophandler.cxx:321: OOXMLDocPropHandler::startFastElement: unknown element 3197 warn:oox:18940:18940:oox/source/docprop/docprophandler.cxx:321: OOXMLDocPropHandler::startFastElement: unknown element 3197 warn:oox:18940:18940:oox/source/docprop/docprophandler.cxx:321: OOXMLDocPropHandler::startFastElement: unknown element 3197 warn:oox:18940:18940:oox/source/docprop/docprophandler.cxx:321: OOXMLDocPropHandler::startFastElement: unknown element 3197 warn:vcl:18940:18940:vcl/source/window/winproc.cxx:836: ImplHandleKey: Keyboard-Input is sent to a frame without focus warn:sc.core:18940:18940:sc/source/core/tool/token.cxx:951: ScTableRefToken::GetSheet - maybe adapt caller to know about TableRef? warn:sc.core:18940:18940:sc/source/core/tool/token.cxx:951: ScTableRefToken::GetSheet - maybe adapt caller to know about TableRef? warn:oox:18940:19064:oox/source/helper/progressbar.cxx:65: ProgressBar::setPosition - invalid position warn:oox:18940:19064:oox/source/helper/progressbar.cxx:65: ProgressBar::setPosition - invalid position warn:oox:18940:19064:oox/source/helper/progressbar.cxx:65: ProgressBar::setPosition - invalid position warn:oox:18940:18940:oox/source/drawingml/shapecontext.cxx:126: ShapeContext::onCreateContext: unhandled element: 3638 warn:oox:18940:18940:oox/source/drawingml/shapecontext.cxx:126: ShapeContext::onCreateContext: unhandled element: 1030 warn:svx.uno:18940:18940:svx/source/unodraw/unoshape.cxx:1620: Unknown Property: GraphicColorMode warn:legacy.osl:18940:18940:oox/source/drawingml/chart/titleconverter.cxx:164: TitleConverter::convertFromModel - multiple text properties warn:oox:18940:18940:oox/source/drawingml/shapecontext.cxx:126: ShapeContext::onCreateContext: unhandled element: 3638 warn:oox:18940:18940:oox/source/drawingml/shapecontext.cxx:126: ShapeContext::onCreateContext: unhandled element: 1030 warn:svx.uno:18940:18940:svx/source/unodraw/unoshape.cxx:1620: Unknown Property: GraphicColorMode warn:legacy.osl:18940:18940:oox/source/drawingml/chart/objectformatter.cxx:1099: ObjectFormatter::convertNumberFormat - cannot create number format '' warn:legacy.osl:18940:18940:oox/source/drawingml/chart/titleconverter.cxx:164: TitleConverter::convertFromModel - multiple text properties warn:oox:18940:18940:oox/source/drawingml/shapecontext.cxx:126: ShapeContext::onCreateContext: unhandled element: 3638 warn:oox:18940:18940:oox/source/drawingml/shapecontext.cxx:126: ShapeContext::onCreateContext: unhandled element: 1030 warn:svx.uno:18940:18940:svx/source/unodraw/unoshape.cxx:1620: Unknown Property: GraphicColorMode warn:legacy.osl:18940:18940:oox/source/drawingml/chart/titleconverter.cxx:164: TitleConverter::convertFromModel - multiple text properties warn:oox:18940:18940:oox/source/drawingml/shapecontext.cxx:126: ShapeContext::onCreateContext: unhandled element: 3972 warn:oox:18940:18940:oox/source/drawingml/shapecontext.cxx:126: ShapeContext::onCreateContext: unhandled element: 3972 warn:oox:18940:18940:oox/source/drawingml/shapecontext.cxx:126: ShapeContext::onCreateContext: unhandled element: 3972 warn:oox:18940:18940:oox/source/drawingml/shapecontext.cxx:126: ShapeContext::onCreateContext: unhandled element: 3972 warn:chart2:18940:18940:chart2/source/view/main/ShapeFactory.cxx:2129: Exception caught. N3com3sun4star3uno9ExceptionE warn:chart2:18940:18940:chart2/source/view/main/ShapeFactory.cxx:2129: Exception caught. N3com3sun4star3uno9ExceptionE warn:chart2:18940:18940:chart2/source/view/main/ShapeFactory.cxx:2129: Exception caught. N3com3sun4star3uno9ExceptionE warn:legacy.osl:18940:18940:svx/source/sdr/contact/viewcontactofe3dscene.cxx:372: No need to get ViewInformation3D from an empty scene (!) warn:chart2:18940:18940:chart2/source/view/main/ShapeFactory.cxx:2129: Exception caught. N3com3sun4star3uno9ExceptionE warn:chart2:18940:18940:chart2/source/view/main/ShapeFactory.cxx:2129: Exception caught. N3com3sun4star3uno9ExceptionE warn:chart2.tools:18940:18940:chart2/source/tools/WrappedPropertySet.cxx:151: found no inner property set to map to warn:chart2.tools:18940:18940:chart2/source/tools/WrappedPropertySet.cxx:151: found no inner property set to map to warn:chart2.tools:18940:18940:chart2/source/tools/WrappedPropertySet.cxx:151: found no inner property set to map to warn:sfx.control:18940:18940:sfx2/source/control/dispatch.cxx:1374: Childwindow slot missing: 25917 warn:sfx.control:18940:18940:sfx2/source/control/dispatch.cxx:1374: Childwindow slot missing: 25917 warn:legacy.tools:18940:18940:svx/source/form/fmvwimp.cxx:444: FmXFormView::~FmXFormView: Window list not empty!
Confirmed in Version: 6.1.0.0.alpha0+ Build ID: 2453c5a62cd2c4364d0258f7488ab23b83b5478b CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk2; TinderBox: Linux-rpm_deb-x86_64@70-TDF-dbg, Branch:master, Time: 2018-01-07_23:15:27 Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded
Created attachment 147898 [details] bt with debug symbols On pc Debian x86-64 with master sources updated today, I could reproduce this.
Regina: according to the bt, the problem seems due to legend-expansion-aspect-ratio. Indeed, this patch prevents from having the assert: diff --git a/xmloff/source/chart/SchXMLExport.cxx b/xmloff/source/chart/SchXMLExport.cxx index 1e59110e84b8..b694d65abf7e 100644 --- a/xmloff/source/chart/SchXMLExport.cxx +++ b/xmloff/source/chart/SchXMLExport.cxx @@ -1372,7 +1372,7 @@ void SchXMLExportHelper_Impl::parseDocument( Reference< chart::XChartDocument > // export legend size const SvtSaveOptions::ODFDefaultVersion nCurrentODFVersion( SvtSaveOptions().GetODFDefaultVersion() ); - if( xLegendShape.is() && nCurrentODFVersion >= SvtSaveOptions::ODFVER_012 ) + if( xLegendShape.is() && nCurrentODFVersion > SvtSaveOptions::ODFVER_012 ) { try { but this attribute should be ok in ODF1.2 according to http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html#__RefHeading__1417936_253892949 Did I miss something?
Argh, forget my last comment, it's not related to legend-expansion-aspect-ratio but to "width" in XML_NAMESPACE_CHART_EXT
Depending of bIsOOoNamespace, either it's true and we use XML_NAMESPACE_CHART_EXT or it's false and we use XML_NAMESPACE_SVG. In our case, the var is put to true, so it's expected we assert if we use ODF 1.2 I must recognize I don't know if bIsOOoNamespace should be put to false here, just found these related commits about it: https://cgit.freedesktop.org/libreoffice/core/commit/?id=e26194b675380ad6b6a1287f97bce93006be176c https://cgit.freedesktop.org/libreoffice/core/commit/?id=c0f7a3f7cf33debd0f6049c415c412d14526a79e If this variable should indeed be put to true, we should just test that nCurrentODFVersion > SvtSaveOptions::ODFVER_012 to call addSize method or not. This would give: diff --git a/xmloff/source/chart/SchXMLExport.cxx b/xmloff/source/chart/SchXMLExport.cxx index 1e59110e84b8..02b03a677599 100644 --- a/xmloff/source/chart/SchXMLExport.cxx +++ b/xmloff/source/chart/SchXMLExport.cxx @@ -1386,7 +1386,8 @@ void SchXMLExportHelper_Impl::parseDocument( Reference< chart::XChartDocument > if( nLegendExpansion == chart::ChartLegendExpansion_CUSTOM) { awt::Size aSize( xLegendShape->getSize() ); - addSize( aSize, true ); + if( nCurrentODFVersion > SvtSaveOptions::ODFVER_012 ) + addSize( aSize, true ); OUStringBuffer aAspectRatioString; ::sax::Converter::convertDouble( aAspectRatioString,
Dear Aron Budea, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
No assert in a recent master debug build, closing as WFM. Version: 7.2.0.0.alpha0+ Build ID: 765b13b67e46aa8c8618fdad8582f8586bffce9e CPU threads: 16; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded