Bug 113850 - calc editing crash ...
Summary: calc editing crash ...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
5.4.3.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 113760 114101 114292 114828 114933 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-11-15 10:51 UTC by Michael Meeks
Modified: 2018-01-09 16:01 UTC (History)
7 users (show)

See Also:
Crash report or crash signature: ["ScEditEngineDefaulter::SetDefaultItem(SfxPoolItem const &)"]

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Meeks 2017-11-15 10:51:45 UTC 
We have a new top crasher for 5.4.3.2 (appeared in 5.4.2 as well it seems):

http://crashreport.libreoffice.org/stats/crash_details/f4ecb46f-05dd-45db-9de5-1da61d286d42

Seems like it comes from:

commit d31a8263d564ebd7886f6debdf36cedd031915ea
Author: Eike Rathke <erack@redhat.com>
Date:   Thu Aug 24 16:34:55 2017 +0200

    Resolves: tdf#108795 merge table EditEngine language attributes to input line
    
    ... when editing there, so the SvxAutoCorrect behaviour is synchronized.
    Depends on commit 06d14411a447cd798d1f0678a3c5e06f5278a1cb that disentangles
    the stateful SvxAutoCorrect instance.

And that the:

            // necessary to sync SvxAutoCorrect behavior
            pHdl->MergeLanguageAttributes( *mpEditEngine);

Can (somehow, sometime) end up with a NULL mpEditEngine.
Comment 1 Michael Meeks 2017-11-15 10:52:55 UTC 
I guess workaround is ~trivial - just avoid NULL mpEditEngine's =) will push a patch shortly.
Comment 2 Michael Meeks 2017-11-15 10:57:37 UTC 
Hmm - this is gone in master; Eike - is it possible we're just missing: 8112af3361fdf15fcf5d3177cd967e1d8d97d5f3 on the -5-4 branch ? =)
Comment 3 Eike Rathke 2017-11-15 11:22:36 UTC 
That one is on 5-4 as 99fdaf683e6403b1d8a70d48ebe0e20194017624, but not in 5.4.3
Comment 4 Michael Meeks 2017-11-15 11:26:42 UTC 
Neato - sorry for the noise then =)
Comment 5 Xisco Faulí 2017-11-16 09:27:53 UTC 
Nice to have this crash fixed!! :-)
Comment 6 Mike Kaganski 2017-11-20 14:32:24 UTC 
Sorry, I didn't get it. There *is* a top crasher for 5.4.3.2 with this signature; even if it's not the same that was fixed for 5.4.older, it doesn't mean that it's fixed?
Comment 7 Michael Meeks 2017-11-20 14:51:56 UTC 
I took Eike's comment to mean that his fix is in the -5-4 branch - ie. it will be in 5.4.4.1 and so on in a month and indeed this one:

commit 99fdaf683e6403b1d8a70d48ebe0e20194017624
Author: Eike Rathke <erack@redhat.com>
Date:   Thu Oct 19 19:23:01 2017 +0200

    Resolves: tdf#113179 merge language attributes early, tdf#108795 follow-up

looks like the commit to that branch =)
Comment 8 Mike Kaganski 2017-11-20 15:01:01 UTC 
Ah! Thanks - and sorry for the noise! (Should study English really.)
Comment 9 Xisco Faulí 2017-12-07 11:58:16 UTC 
*** Bug 114292 has been marked as a duplicate of this bug. ***
Comment 10 Xisco Faulí 2017-12-07 12:01:32 UTC 
*** Bug 113760 has been marked as a duplicate of this bug. ***
Comment 11 Xisco Faulí 2017-12-07 12:01:56 UTC 
*** Bug 114101 has been marked as a duplicate of this bug. ***
Comment 12 Xisco Faulí 2018-01-03 18:25:17 UTC 
*** Bug 114828 has been marked as a duplicate of this bug. ***
Comment 13 Xisco Faulí 2018-01-09 16:01:39 UTC 
*** Bug 114933 has been marked as a duplicate of this bug. ***