Bug 114261 - Modifying a toolbar entry with a set toolbar:style attribute causes the attribute to be removed
Summary: Modifying a toolbar entry with a set toolbar:style attribute causes the attri...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
6.1.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Maxim Monastirsky
URL:
Whiteboard: target:6.1.0
Keywords:
Depends on:
Blocks: Customize-Dialog
  Show dependency treegraph
 
Reported: 2017-12-05 13:33 UTC by Yousuf Philips (jay) (retired)
Modified: 2017-12-09 23:36 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2017-12-05 13:33:17 UTC
steps:
1. open writer
2. activate print preview
3. notice 'close preview' button has text
4. customize the print preview toolbar and hide the button by unchecking it
5. without closing the dialog, check it again and now an image appears rather than the button text

So unchecking the entry simply adds the toolbar:visible attribute to the entry, but checking it again removes the toolbar:style attribute.

Version: 6.1.0.0.alpha0+
Build ID: 2618e4a13d719122e6358d9d96864d1691e56a02
CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk2; 
Locale: en-US (en_US.UTF-8); Calc: group threaded
Comment 1 Thomas Lendo 2017-12-05 21:03:50 UTC
Confirmed with the daily master for Windows from today, also described in comment 0 of bug 114265.
Comment 2 Maxim Monastirsky 2017-12-09 21:56:21 UTC
https://gerrit.libreoffice.org/46169/
Comment 3 Commit Notification 2017-12-09 23:36:31 UTC
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=202f46bfdeca9110ee37a06c848c505a05739a8f

tdf#114261 Retain toolbar:style after customization

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.