Description: Tangut characters shifted to the right vertical layout, leaves a narrow gap after CJK characters. Steps to Reproduce: 1. Open Yu Luo Jun Mei Shu.odt Actual Results: See attached screenshot Expected Results: LiberOffice should not insert gap between Chinese and Tangut characters, and Tangut characters should aligned the same as Chinese Characters in vertical layout. See the example: https://en.wikipedia.org/w/index.php?title=Wikipedia:Sandbox&oldid=815160812 Reproducible: Always User Profile Reset: No Additional Info: Version: 6.0.0.0.beta2+ (x64) Build ID: b030bf19e29f031b0a640dd92c38d654785f1a99 CPU threads: 4; OS: Windows 10.0; UI render: default; TinderBox: Win-x86_64@42, Branch:libreoffice-6-0, Time: 2017-12-12_05:03:02 Locale: zh-CN (zh_CN); Calc: group threaded User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Created attachment 138407 [details] Sample ODT
Created attachment 138408 [details] Snapshot
You can try Tangut Yinchuan for test. http://www.babelstone.co.uk/Fonts/Yinchuan.html
Created attachment 138474 [details] Screenshot: Comparion Sorry, I don't know how to describe it properly, please see the attached screenshot. It seems to depend on ... 1. the chinese font you are using and 2. the first character of a line. Compared to other fonts, Noto Sans CJK and Noto Serif CJK seem to shift to left a lot, and the characters are overlapped with underline. --- Version: 6.1.0.0.alpha0+ Build ID: aad9c6da5154a89c6ef02214d1122d4b444eea23 CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk2; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2017-12-15_23:20:39 Locale: zh-TW (zh_TW.UTF-8); Calc: group threaded
OK, for me, the problem looks the same as what you have seen with Noto Sans CJK and Noto Serif CJK, however characters aren't overlapped with underline. Version: 6.0.0.0.beta2+ (x64) Build ID: bd260a59cfdd050db3aa9a641ef0fa09efcedf5b CPU threads: 4; OS: Windows 10.0; UI render: default; TinderBox: Win-x86_64@42, Branch:libreoffice-6-0, Time: 2017-12-16_05:54:16 Locale: zh-CN (zh_CN); Calc: group threaded
Created attachment 138559 [details] Screenshot: Comparion Here is what I have seen on Windows. Version: 6.0.0.0.beta2+ (x64) Build ID: fe31edb29e5e77bb60e3aa73ec6a0380314acc61 CPU threads: 4; OS: Windows 10.0; UI render: default; TinderBox: Win-x86_64@42, Branch:libreoffice-6-0, Time: 2017-12-20_03:45:21 Locale: zh-CN (zh_CN); Calc: group
Let's set to NEW per comment 4
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Dear Volga, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Created attachment 173137 [details] Screenshot from 7.3.0.0.alpha0+ The Tangut characters still have gap at the top. As a suggection, in vertical text layout, they should apply the same alignment as CJK Ideographs, Kana and Hangul. Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: f6b9f671d128c989ce223d61d0d5d43ff1dc9fcb CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: zh-CN (zh_CN); UI: zh-CN Calc: threaded Use this font: https://mirrors.tuna.tsinghua.edu.cn/adobe-fonts/source-han-serif/OTF/SimplifiedChinese/SourceHanSerifSC-Regular.otf
Does not seem to be reproducible any more. Please re-open if reproducible.
Created attachment 188028 [details] Screenshot from LibreOffice Writer 7.5.4.2 I see there are no change for this, further more, Khitan Small Script is now encoded in Unicode, which is another writing system inspired by Chinese characters, so there's necessary to fix this bug. Version: 7.5.4.2 (X86_64) / LibreOffice Community Build ID: 36ccfdc35048b057fd9854c757a8b67ec53977b6 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: zh-CN (zh_CN); UI: zh-CN Calc: threaded
OK, I see the issue now. Any new CJK scripts in Unicode other than Tangut and Khitan Small Script?
Created attachment 188029 [details] Orignal text This is the original text I have extracted, the source can be seen in attachment 138407 [details]. Here you can see althrough there's some character spacing in content, no extra spacing between Chinese and Tangut characters.
(In reply to خالد حسني from comment #13) > OK, I see the issue now. Any new CJK scripts in Unicode other than Tangut > and Khitan Small Script? On Unicode website (https://www.unicode.org/charts/) I see no new CJK scripts encoded in Unicode so far. But I believe LibreOffice should be treated siniform scripts the same for content layout, and be prepared for new comer if it was adopted in new version of the Unicode Standard, for example, Jurchen script.
(In reply to Volga from comment #15) > (In reply to خالد حسني from comment #13) > > OK, I see the issue now. Any new CJK scripts in Unicode other than Tangut > > and Khitan Small Script? > On Unicode website (https://www.unicode.org/charts/) I see no new CJK > scripts encoded in Unicode so far. But I believe LibreOffice should be > treated siniform scripts the same for content layout, and be prepared for > new comer if it was adopted in new version of the Unicode Standard, for > example, Jurchen script. How to identify a siniform script in a future-proof way? We are currently using ICU script codes, so we can only check scripts that are already encoded.
Khaled Hosny committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/bb2c55b2c8f72bfbb7f98cf88911cb88ee1a71d6 tdf#114432: classify Tangut and Khitan Small Script as ScriptType::ASIAN It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Should this to be backport to 7.6beta?
Khaled Hosny committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/914e45a65818a52b7469161b5970db4b8c7c66a5 tdf#114432: classify Tangut and Khitan Small Script as ScriptType::ASIAN It will be available in 7.6.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.