Bug 114455 - SfxVoidItem::Clone(SfxItemPool*) leaks memory with multiple invocations
Summary: SfxVoidItem::Clone(SfxItemPool*) leaks memory with multiple invocations
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.1.0.0.alpha0+
Hardware: All macOS (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Memory
  Show dependency treegraph
 
Reported: 2017-12-14 09:41 UTC by Telesto
Modified: 2023-01-12 03:20 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot (406.53 KB, image/png)
2017-12-14 09:45 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2017-12-14 09:41:21 UTC
Description:
SfxVoidItem::Clone(SfxItemPool*) leaks memory with multiple invocations

Steps to Reproduce:
Steps to Reproduce:
1. Start the Instruments
2. Choose Memory Leak profile tool
3. Select LibreOffice.app in instdir as target process
4. Click on the record button, LODev is started by the profiling tool
5. Wait for the StartCenter to load.
6. Click on the new Writer document icon to open a blank Writer document.
7. Type a line of text, with multiple misspelled words. Click the red-underlined words  and select a suggestion (do this a few times). 

Actual Results:  
Small memory leak

Expected Results:
No leak at all


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.1.0.0.alpha0+
Build ID: d46dc8e547810208287aab77f0313f1971901464
CPU threads: 4; OS: Mac OS X 10.12.6; UI render: default; 
TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2017-12-08_10:35:46
Locale: nl-NL (nl_NL.UTF-8); Calc: group threaded


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/603.3.8 (KHTML, like Gecko) Version/10.1.2 Safari/603.3.8
Comment 1 Telesto 2017-12-14 09:45:12 UTC
Created attachment 138436 [details]
Screenshot

No symbols, sorry..
Comment 2 Alex Thurgood 2017-12-15 07:36:51 UTC
Isn't this a follow-on, or related fallout, from bug 112395 ?
Comment 3 Julien Nabet 2017-12-16 20:24:14 UTC
On MacOs with master sources updated today, I could reproduce this.

Alex: since SfxVoidItem::Clone, SfxBoolItem::Clone or similar may be called from different locations and since the mem management of ItemPool seems complicated (if I well understood https://bugs.documentfoundation.org/show_bug.cgi?id=112395#c5) I suppose we'll encounter a bunch of memleaks because of itempools
Comment 4 Julien Nabet 2017-12-16 20:29:38 UTC
I submitted this on gerrit for review:
https://gerrit.libreoffice.org/#/c/46613/
Comment 5 Commit Notification 2017-12-17 10:44:36 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2f9360b58a358fefb86f474464e53f1ea5ffb52b

Related tdf#114455: fix mem leak on olmenu (sw)

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Julien Nabet 2017-12-19 19:57:23 UTC
After some tests on MacOs, it seems it doesn't help.
I submitted a revert, as soon as it's verified by Jenkins, I push this.
I won't be able to help here so uncc myself.
Comment 7 Commit Notification 2017-12-20 06:02:33 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5a38ae7bb491df71bfc1678811d89c3064fd8408

Revert "Related tdf#114455: fix mem leak on olmenu (sw)"

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Telesto 2018-11-11 11:32:46 UTC
Still reproducible
Version: 6.2.0.0.alpha1+
Build ID: 30df4a32449f3b717e77eb447583730e026b7d17
CPU threads: 4; OS: Mac OS X 10.12.6; UI render: default; VCL: osx; 
TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2018-11-11_07:42:44
Locale: nl-NL (nl_NL.UTF-8); UI-Language: en-US
Calc: threaded
Comment 9 QA Administrators 2021-01-11 03:55:16 UTC Comment hidden (obsolete)
Comment 10 QA Administrators 2023-01-12 03:20:45 UTC
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug