Description: OfaTreeOptionsDialog::LoadNodes(Module*, rtl::OUString const&) is leaking a bit Steps to Reproduce: 1. Start the Instruments 2. Choose Memory Leak profile tool 3. Select LibreOffice.app in instdir as target process 4. Click on the record button, LODev is started by the profiling tool 5. Wait for the StartCenter to load. 6. Open A writer document 7. Go to LibreOffice Menu -> Preferences 8. Expand Load/Save - >General 9. Change the Autosave Autorecovery time to something else 10. Press OK 11. Type something (not sure if this relevant..) Actual Results: Small leak Expected Results: No leak Reproducible: Always User Profile Reset: No Additional Info: Version: 6.1.0.0.alpha0+ Build ID: d46dc8e547810208287aab77f0313f1971901464 CPU threads: 4; OS: Mac OS X 10.12.6; UI render: default; TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2017-12-08_10:35:46 Locale: nl-NL (nl_NL.UTF-8); Calc: group threaded User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/603.3.8 (KHTML, like Gecko) Version/10.1.2 Safari/603.3.8
Created attachment 138439 [details] Screenshot
With master sources updated today, I don't reproduce this on MacOs. I tried twice by following each step, I even tried to display several options in prefs but nothing. However, I submitted a patch to review because I think having found something wrong in this part of code: https://gerrit.libreoffice.org/#/c/46602/
Julien Nabet committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=41981d4cb48e66b6fdb32cdc3ae65632af9593dc Related tdf#114457: fix leak in treeopt (cui) It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Telesto: with a build including http://cgit.freedesktop.org/libreoffice/core/commit/?id=41981d4cb48e66b6fdb32cdc3ae65632af9593dc, could you give a new try?
Created attachment 138530 [details] screenshot Looks worse to me: Version: 6.1.0.0.alpha0+ Build ID: 184ce84226b49a1b4b693f3bb8cc8569c76d864d CPU threads: 4; OS: Mac OS X 10.12.6; UI render: default; TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2017-12-18_23:53:27 Locale: nl-NL (nl_NL.UTF-8); Calc: group threaded
Thank you for your feedback. I submitted a revert, as soon as it's verified by Jenkins, I push this. I won't be able to help here so uncc myself.
Julien Nabet committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=cf4228fa0aaea82858f05848fe5a6a96b34405a0 Revert "Related tdf#114457: fix leak in treeopt (cui)" It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Confirming with Version: 6.1.0.0.alpha0+ Build ID: dd758f54fa5ea1ecd3d793bcea999d771010ff00 CPU threads: 4; OS: Mac OS X 10.13.2; UI render: default; Locale: fr-FR (fr_FR.UTF-8); Calc: group threaded It seems to be happening here : do { SolarMutexReleaser aReleaser; SAL_WNODEPRECATED_DECLARATIONS_PUSH // 'NSAnyEventMask' is deprecated: first deprecated in macOS 10.12 pEvent = [NSApp nextEventMatchingMask: NSAnyEventMask SAL_WNODEPRECATED_DECLARATIONS_POP untilDate: nil inMode: NSDefaultRunLoopMode dequeue: YES]; if( pEvent ) { [NSApp sendEvent: pEvent]; if ( isWakeupEvent( pEvent ) ) continue; bHadEvent = true; } lines 596 to 613 of salinst.cxx, and in particular: pEvent = [NSApp nextEventMatchingMask: NSAnyEventMask and [NSApp sendEvent: pEvent];
Note that I don't see the leak in : OfaTreeOptionsDialog::LoadNodes(Module*, rtl::OUString const&)
Perhaps these patches would help: https://cgit.freedesktop.org/libreoffice/core/commit/?id=7794b2d96f5259b062ca6bd9db265a086631593f + https://cgit.freedesktop.org/libreoffice/core/commit/?id=42bfd59b6ba9e7a53ba789f04694060cc43d9d88 I used unique_ptr at different locations to try to improve memory management.
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Following commits quoted in my previous comment, any better with a recent LO version (eg 6.2.4)?
Dear Telesto, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping
Dear Telesto, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp