Description: Calc cannot handle sheets with more than 1024 columns. Some files opened by calc will contain sheets with more than this (for example spreadsheets created with Excel can have up to ~16,000 columns). The current behaviour is to silently truncate the sheets at the 1024 column mark (AMJ). This can lead to the user being unaware that the spreadsheet is incomplete. If the user saves the file, these columns will be permanently lost. I propose that a clear warning is given when a user opens a file with over 1024 columns informing them that not all columns are being displayed and that saving the file will lead to loss of data. Steps to Reproduce: 1. Open a file saved by Excel with a sheet with more than 1024 columns 2. Save the file Actual Results: The large sheet is truncated after column 1024 (AMJ). No warning of this is given. The saved file is smaller and no longer contains these columns. Expected Results: A warning informs the user that truncation has occured. Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.90 Safari/537.36
For what it's worth, there is ongoing work to get rid of this limitation: bug 50916
Created attachment 138723 [details] warning for csv file Hi, for csv file it works. Please,could you attach testing xlsx file with more then 1024 columns?
Created attachment 138808 [details] A .xlsx saved by Excel. It has the value 'Hi' in column XFD, giving it 16,384 columns.
(In reply to Buovjaga from comment #1) > For what it's worth, there is ongoing work to get rid of this limitation: > bug 50916 Understood, and I look forward to the 6.x series where this no longer an issue. However if people are going to be presumably using 5.x for a while longer, this is an issue that should be patched IMO.
Confirming. Eike, it's similar to bug 43911. Could you add such warning for xlsx too?
After having dug around a lot.. seems so.
Eike Rathke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f2a4cea6c035e9a837942934068b5f80a996580a Resolves: tdf#114555 check .xlsx col/row/tab overflow and display warning It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Eike Rathke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ed7cd31848201e8bc6d4ec69e397ff2e6e154b50 Revert "Resolves: tdf#114555 check .xlsx col/row/tab overflow and display warning" It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Eike Rathke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=66564dac88ffcc781b4fade7ca0f4f72af6b8bca Resolves: tdf#114555 check .xlsx col/row/tab overflow and display warning It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Pending review https://gerrit.libreoffice.org/50570 for 6-0
Eike Rathke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ccc977ba10b61108a56e00a79c0f7a1517e026cc Related: tdf#114555 cater for lastcolumn+1 oddity if last is last possible It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Tried with Version: 6.1.0.0.alpha0+ Build ID: 4647057a077824cd6782be82b2d13e06fa76704b CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk2; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2018-03-13_00:16:40 Locale: en-ZA (en_ZA.UTF-8); Calc: group Unfortunately get the same error.
(In reply to Elmar from comment #12) > Tried with > Version: 6.1.0.0.alpha0+ > Build ID: 4647057a077824cd6782be82b2d13e06fa76704b > CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk2; > TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: > 2018-03-13_00:16:40 > Locale: en-ZA (en_ZA.UTF-8); Calc: group > > Unfortunately get the same error. I'm sorry, but 1. What did you try? 2. What is the "error"?
(In reply to Buovjaga from comment #13) > I'm sorry, but > 1. What did you try? > 2. What is the "error"? Elmar: see above.
Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-6-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=621634923ab7c11ceef9757c481f92977ef863f6&h=libreoffice-6-0 Resolves: tdf#114555 check .xlsx col/row/tab overflow and display warning It will be available in 6.0.4. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Thank you Eike. Any chance of this being applied to the 5.X series also?
Rather not. This change is somewhat intrusive and 5.4.7 will be the last release for 5-4 so if anything went wrong there would be no chance to correct it.
Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-6-0-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=828e41a91742a55f213c1c9cd93efa4cf73bdf3c&h=libreoffice-6-0-3 Resolves: tdf#114555 check .xlsx col/row/tab overflow and display warning It will be available in 6.0.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Can confirm it worked perfectly using 6.0.4.2 with a file I found in the wild. Thank you.
Eike, in order to finish discussion in Bug 116274, can you please explain if it's possible to have more specific warning like: "max number of columns exceeded in sheet 'Name1', 'Name2'" To open another enhancement. Although it's only until Bug 50916 is resolved.