Bug 114575 - Autocorrect replacement mixes up Hebrew opening and closing quotes
Summary: Autocorrect replacement mixes up Hebrew opening and closing quotes
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Linguistic (show other bugs)
Version:
(earliest affected)
6.0.0.0.beta2
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 114637
  Show dependency treegraph
 
Reported: 2017-12-19 23:22 UTC by Eyal Rozenberg
Modified: 2019-02-11 16:50 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Without AC, with incorrect AC, with "corrected" AC (11.45 KB, application/vnd.oasis.opendocument.text)
2017-12-19 23:22 UTC, Eyal Rozenberg
Details
Bug manifestation (10.99 KB, application/vnd.oasis.opendocument.text)
2019-02-05 17:25 UTC, Eyal Rozenberg
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eyal Rozenberg 2017-12-19 23:22:50 UTC
Created attachment 138539 [details]
Without AC, with incorrect AC, with "corrected" AC

When you apply autocorrect replacement of simple quotes with "smart" quotes on Hebrew text (within two simple ASCII double-quote characters), what you get is that the first double-quote (i.e. the right double-quote, as Hebrew is written in RTL) gets replaced with a Hebrew closing-quote character, and the second double-quote (i.e. the left one) gets replaced with a Hebrew upper-opening-quote character. That's the wrong order:

Instead of this (added RLMs to the beginning and end of the line to get the direction right):
‏
‏הבית של פיסטוק מלא “הפתעות”.‏

we should be getting this:

‏הבית של פיסטוק מלא ”הפתעות“.‏

if you can't see the difference, open the example.

Also, for good measure, if the paragraph's style was LTR, and you only manually set it to LTR, the autocorrect resets the direction to LTR. This is a different issue, but I'm mentioning it so that when you try to reproduce, you'll want to double-check the direction after the autocorrect has been applied. Finally, if autocorrect does not, well, autocorrect (which happens to me sometime), manually Apply it using the menus.
Comment 1 Eyal Rozenberg 2017-12-21 21:04:27 UTC
Same problem occurs with single-quotes, it seems.
Comment 2 Xisco Faulí 2018-06-12 11:17:50 UTC
Thank you for reporting the bug.
Could you please try to reproduce it with the latest version of LibreOffice
from https://www.libreoffice.org/download/libreoffice-fresh/ ?
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the bug is still present in the latest version.
Comment 3 Eyal Rozenberg 2018-06-12 11:55:17 UTC
Right now I can't get LO 6.1.0.0b1 to apply any sort of autocorrection to Hebrew double-quotes.
Comment 4 Xisco Faulí 2019-02-05 16:31:57 UTC
(In reply to Eyal Rozenberg from comment #3)
> Right now I can't get LO 6.1.0.0b1 to apply any sort of autocorrection to
> Hebrew double-quotes.

What about LibreOffice 6.2.0.3 from https://wiki.documentfoundation.org/QA/GetInvolved#Test_Pre-releases ?
Comment 5 Eyal Rozenberg 2019-02-05 17:23:13 UTC
So, I don't think this has changed betwen 6.1 and 6.2, and I am having difficulty reproducing, but I _do_ manage to reproduce if I add a punctuation mark before the opening quote.

So, new reproduction instructions:

1. Create a new writer document.
2. Enable Autocorrect-as-you-type, and specifically double-quote autocorrection.
3. Set the paragraph direction to RTL and the language to Hebrew.
4. Set your font to something large, and in which you can tell the difference between the various double-quote glyphs. Liberation Serif works nicely.
5. Type the phrase "הבית של פיסטוק." (without the quotes but with the period).
6. Type a double-quote.
7. Type "מלא הפתעות" (without the quotes)
8. Type a double quote.

Expected:

1. The first (rightmost) quote is a Hebrew opening double-quote: ” ; it points leftwards and downwards.
2. The second (leftmost) quote is a Hebrew closing double-quote: “ ; it points rightwards and downwards. 

Actual:

The opposite, i.e. the first quote is a closing double quote, the second quote is opening.

Build info:
Version: 6.2.0.3
Build ID: 98c6a8a1c6c7b144ce3cc729e34964b47ce25d62
CPU threads: 4; OS: Linux 4.9; UI render: default; VCL: gtk3; 
Locale: he-IL (en_IL); UI-Language: en-US
Comment 6 Eyal Rozenberg 2019-02-05 17:25:36 UTC
Created attachment 148929 [details]
Bug manifestation

Lines in the attached document:

Line 1: With problematic AC; 
Line 2: Expected AC results; 
Line 3: No AC - simple double quotes, identical on both sides
Comment 7 Xisco Faulí 2019-02-06 18:02:18 UTC
(In reply to Eyal Rozenberg from comment #5)
> So, I don't think this has changed betwen 6.1 and 6.2, and I am having
> difficulty reproducing, but I _do_ manage to reproduce if I add a
> punctuation mark before the opening quote.

is the punctuation mark problem the same as reported in bug 114637?
Comment 8 Eyal Rozenberg 2019-02-06 18:46:02 UTC
(In reply to Xisco Faulí from comment #7)
> is the punctuation mark problem the same as reported in bug 114637?

There's no problem with the punctuation mark itself, it just triggers a switching of the double quotation marks.