Bug 114982 - AdminConsole: control logging ...
Summary: AdminConsole: control logging ...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice Online
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Gökay ŞATIR
URL:
Whiteboard: target:7.1.0
Keywords: difficultyMedium, easyHack, skillCpp, skillJavaScript, topicCleanup
Depends on:
Blocks: LOOL-Admin-Console
  Show dependency treegraph
 
Reported: 2018-01-12 16:53 UTC by Michael Meeks
Modified: 2020-12-08 09:07 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Meeks 2018-01-12 16:53:48 UTC
It would be extremely useful to be able to turn up and down the log-level on the admin-console (and to browse the logs but that's something else ;-) dynamically at run time.

This belongs in the 'Settings' page - checkout:

loleaflet/dist/admin/adminSettings.html
loleaflet/src/admin/AdminSocketSettings.js

To add the log level setting and then:

wsd/Admin.cpp-    else if (tokens[0] == "settings")

wsd/protocol.txt: needs updating too.

And of course we need to set the log level with:

        Log::logger().setLevel(LogLevel);

For bonus points we should really propagate this to all the WSD children too including the forkit - but that is a fair bit of protocol work & tweaking =)

Thanks !
Comment 1 Gökay ŞATIR 2020-05-04 19:02:36 UTC
Hello,

Can i work on this task?
Comment 2 Michael Meeks 2020-05-04 19:08:38 UTC
Sure ! =) go for it ...
Comment 3 Commit Notification 2020-05-30 09:10:47 UTC
gokaysatir committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/online/commit/ac682772a6edf4045371670552a9c831623d45f4

tdf#114982 - AdminConsole: control logging
Comment 4 Gökay ŞATIR 2020-05-30 09:19:38 UTC
Things done:

* Set log level of each channel.
* View the log via admin console.
* Update protocol.txt

Things to be done:
* Propagate the new log level to the WSD children including forkit.


This task still needs some work to be done. I will send one more patch. This will take a while.

Thank you for leading the way:)
Comment 5 Gökay ŞATIR 2020-12-08 09:07:21 UTC
I didn't forget this one :) After some months. This bug is ready to be closed. Below task is also done and merged into master branch.

* Propagate the new log level to the WSD children including forkit.