Bug 115011 - gpg4libre: some unit-test documents have assertion failed
Summary: gpg4libre: some unit-test documents have assertion failed
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
6.1.0.0.alpha0+
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Thorsten Behrens (allotropia)
URL:
Whiteboard: target:6.1.0 target:6.0.1 target:6.0.0
Keywords:
Depends on:
Blocks: Crash-Assert
  Show dependency treegraph
 
Reported: 2018-01-15 00:46 UTC by Regina Henschel
Modified: 2018-01-17 09:19 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Output from VS 2017 (3.53 KB, text/plain)
2018-01-16 14:07 UTC, Regina Henschel
Details
output from VS 2017 after assertion (4.46 KB, text/plain)
2018-01-16 14:40 UTC, Regina Henschel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2018-01-15 00:46:18 UTC
I have got a debug build Version: 6.1.0.0.alpha0+ (x64)
Build ID: 61618210f87f57ae21cc39530c9f777d76002a12
CPU threads: 8; OS: Windows 10.0; UI render: default; 
Locale: de-DE (de_DE); Calc: CL

gpg4win is not installed.

When I open the files  badDsigGPG.odt, badStreamGPG.odt, goodGPG.odt, or untrustedGoodGPG.odt from /core/xmlsecurity/qa/unit/signing/data/ I get a red warning: This document has an invalid signature. If I then click on button "Show Signatures" I get the message Assertion failed!
File: core\include/com/sun/star/uno/Reference.h
Line:420
Expression: _pInterface != NULL
Comment 1 Thorsten Behrens (allotropia) 2018-01-16 10:29:08 UTC
Which translates into a crash for release builds. Taking over.
Comment 2 Thorsten Behrens (allotropia) 2018-01-16 10:45:06 UTC
(In reply to Regina Henschel from comment #0)
> File: core\include/com/sun/star/uno/Reference.h
> Line:420
> Expression: _pInterface != NULL

Can you please attach the backtrace from there perhaps?
Comment 3 Regina Henschel 2018-01-16 14:07:08 UTC
Created attachment 139130 [details]
Output from VS 2017

(In reply to Thorsten Behrens (CIB) from comment #2)
> (In reply to Regina Henschel from comment #0)
> > File: core\include/com/sun/star/uno/Reference.h
> > Line:420
> > Expression: _pInterface != NULL
> 
> Can you please attach the backtrace from there perhaps?

How do I that? If I set a breakpoint in VS 2017 in Reference.h line 420,  it triggers always and I can not even switch to running LibreOffice, not to mention loading a document or clicking the "Show Signature" button.

Nevertheless, the attachment is what I get from VS 2017 with breakpoint in line 420.
Comment 4 Commit Notification 2018-01-16 14:28:04 UTC
Thorsten Behrens committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=03afd4b72431a0dc197891d41fb7bf2419858380

tdf#115011 don't crash on non-existent gpg support

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Regina Henschel 2018-01-16 14:40:45 UTC
Created attachment 139131 [details]
output from VS 2017 after assertion

This looks better. Simple attached soffice.bin without using any breakpoint.
Comment 6 Commit Notification 2018-01-16 20:55:02 UTC
Thorsten Behrens committed a patch related to this issue.
It has been pushed to "libreoffice-6-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=f9839a5b74963e881f914ffe3a9b36029ded3585&h=libreoffice-6-0

tdf#115011 don't crash on non-existent gpg support

It will be available in 6.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2018-01-17 09:19:59 UTC
Thorsten Behrens committed a patch related to this issue.
It has been pushed to "libreoffice-6-0-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=b42af46a09517cc6538d44fd360a812c14b937b8&h=libreoffice-6-0-0

tdf#115011 don't crash on non-existent gpg support

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.