Bug 115170 - configure arbitrary sockets for loolwsd including unix-domain sockets
Summary: configure arbitrary sockets for loolwsd including unix-domain sockets
Status: RESOLVED DUPLICATE of bug 115163
Alias: None
Product: LibreOffice Online
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-23 13:49 UTC by Andras Timar
Modified: 2018-01-30 11:56 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andras Timar 2018-01-23 13:49:57 UTC 
LOOL is bound to INADDR_ANY:9980. It should probably bind to INADDR_LOOPBACK:9980 instead. In loolwsd.xml I don't see where to set the INET address to listen on (to replace INADDR_ANY with INADDR_LOOPBACK).
Comment 1 guilhem 2018-01-23 14:17:27 UTC 
(Was my comment regarding TDF's LOOL instance.)  I believe loolwsdf should bind to the loopack interface, but the listening socket should ideally be configurable, and support AF_UNIX, AF_INET, and AF_INET6 families.
Comment 2 Michael Meeks 2018-01-25 09:58:43 UTC 
AF_UNIX is a chunk of work - but it is configurable between IPv4 and IPv6 - cf. the config file ;-)

I believe our internal 9981 socket is purely local.

It should be easy enough to change:

    /// Create the externally listening public socket
    std::shared_ptr<ServerSocket> findServerPort(int port)
...
        std::shared_ptr<ServerSocket> socket = getServerSocket(
            ServerSocket::Type::Public, port, WebServerPoll, factory);

to pass ServerSocket::Type::Local instead - in the case that we don't want to listen publicly there.

Should be an easy enough config option to add - go for it ;-)
Comment 3 Pranav Kant 2018-01-30 11:56:05 UTC 

*** This bug has been marked as a duplicate of bug 115163 ***