Follow-on to bug 104901 complaining of image object cumulative placement error in a .ods standard edit mode window then also flowing downstream to Print Preview view and PDF output files. Bug 104901 now RESOLVED/WORKSFORME in LO v6.1 for edit mode window, however, misplacement now continues as a distinct issue in downstream Print Preview and PDF exports. Comparison screenshot PNG showing edit window along with Print Preview window is here: https://bug-attachments.documentfoundation.org/attachment.cgi?id=139351 Test ODS to follow. Tested with: Version: 5.4.4.2 (x64) Build ID: 2524958677847fb3bb44820e40380acbe820f960 CPU threads: 8; OS: Windows 6.19; UI render: default; Locale: en-US (en_US); Calc: group Windows 10 x64 v1709 on native Intel-driven display and Version: 6.1.0.0.alpha0+ (x64) Build ID: 8a73799d12f0d2dc04890b96bd0adf0ffcf50d17 CPU threads: 8; OS: Windows 10.0; UI render: GL; TinderBox: Win-x86_64@42, Branch:master, Time: 2018-01-25_23:42:12 Locale: en-US (en_US); Calc: CL Windows 10 x64 v1709 on native Intel-driven display
Created attachment 139398 [details] 2018-01 bug 115262 test ODS for Print Preview image misplacement Test ODS with LO logo images in rows 3, 100, 200, 300, 400, 500 (yellow bckgrnd). Each row has 2 images, one using LO image object border function the other not. Slightly different misplacement behavior has been observed between the two.
Repro with Version: 6.1.0.0.alpha0+ Build ID: ea89dabf8b6363972190a6b50c527c418d51c2c7 CPU threads: 4; OS: Windows 6.3; UI render: default; TinderBox: Win-x86@42, Branch:master, Time: 2018-01-27_22:55:15 Locale: nl-NL (nl_NL); Calc: CL and with Version: 5.1.0.3 Build ID: 5e3e00a007d9b3b6efb6797a8b8e57b51ab1f737 CPU Threads: 4; OS Version: Windows 6.2; UI Render: default; Locale: en-US (nl_NL) but not with: Version: 5.0.6.3 Build ID: 490fc03b25318460cfc54456516ea2519c11d1aa Locale: en-US (nl_NL)
Created attachment 139407 [details] Bibisect log Regression introduced by: author Miklos Vajna <vmiklos@collabora.co.uk> 2015-11-02 10:56:43 +0100 committer Miklos Vajna <vmiklos@collabora.co.uk> 2015-11-02 10:57:44 +0100 commit 708d1c5ab242b545ced598879233fc662d7e6cc0 (patch) tree 518fe8cf520cf82dfc89e1e1f967423749f2f926 parent f570f837d65c9ee79a10be823c3dc28febdebfc8 (diff) sc lok: emit RowColumnHeader info in twips As that's the unit we use everywhere else in the LOK API. Also, make the ScGlobal::nScreenPPTX/Y calculation more precise, otherwise rounding errors occur during the pixel -> twip conversion. Example with the old precision: col height is 103 px, nScreenPPTY is 0.067, twips is 1537.3134328358208, convering it back is 102.487562189 px. Example with the new precision: col height is 103 px, nScreenPPTY is 0.0667, twips is 1544.2278860569716, convering it back is 102.948525737 px.
Adding CC to: Miklos Vajna
Adding Cc to: Miklos Vajna
Adding Cc: to Miklos Vajna
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=616fd241838069e18c59064e33c4b24f5ae112c6 tdf#115262 sc: fix cumulative placement error of images It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified in Version: 6.2.0.0.alpha0+ Build ID: 8ea0b0f4dc5eba2d0bafc2e42415ef1824ff604e CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: threaded @Miklos, thanks for fixing this!!
Cherry-picked to 6-1 -> https://gerrit.libreoffice.org/#/c/61312/
Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-6-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=60011cefbccd91065dadf66896a688b807e76964&h=libreoffice-6-1 tdf#115262 sc: fix cumulative placement error of images It will be available in 6.1.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.