Description: Tabbed/Notebookbar's Shapes Box title is garbage. Steps to Reproduce: 1. Create Ne Writer Document 2. Set Tabbed/NoteBookbar Menu - View - Toolbar Layout - Notebookbar Menu - View - Notebookbar - Tabbed 3. Open Insert tab 4. Click(pulldown) a "Insert Basic Shapes" Actual Results: 5. "Basic Shapes" Box's title is garbage Expected Results: 5. "Basic Shapes" Box's title is displayed Reproducible: Always User Profile Reset: No Additional Info: Version: 6.0.0.3 (x64) Build ID: 64a0f66915f38c6217de274f0aa8e15618924765 CPU threads: 4; OS: Windows 10.0; UI render: default; Locale: ja-JP (ja_JP); Calc: group Version: 6.1.0.0.alpha0+ (x64) Build ID: 8a73799d12f0d2dc04890b96bd0adf0ffcf50d17 CPU threads: 4; OS: Windows 10.0; UI render: default; TinderBox: Win-x86_64@62-TDF, Branch:master, Time: 2018-01-25_23:51:50 Locale: ja-JP (ja_JP); Calc: group threaded User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Created attachment 139404 [details] Screenshot
On pc Debian x86-64 with master sources updated yesterday + gen rendering, I could reproduce this. This part doesn't appear with gtk3. Heiko: thought you might be interested in this one.
What do you mean by "garbage"? I see nothing wrong in your screenshot.
(In reply to Maxim Monastirsky from comment #3) > What do you mean by "garbage"? I see nothing wrong in your screenshot. Just above the shapes, you've got this kind of line: *********
(In reply to Julien Nabet from comment #4) > Just above the shapes, you've got this kind of line: > ********* And what's wrong with it? It's a dragging grip which one can use to drag that popup window, to turn it into a standalone floating toolbar. It was always there (since OOo days), except that before 5.4 that grip was at the bottom, and since 5.4 it's on the top (since https://cgit.freedesktop.org/libreoffice/core/commit/?id=a4d1dea6c79fedf8a5d21d14e4b1077ee0edd5f8). The dots that we draw there are the same dots you see in the dragging grip of a vertically docked toolbar (+ the white background).
(In reply to Maxim Monastirsky from comment #5) > ... > And what's wrong with it? It's a dragging grip which one can use to drag > that popup window, to turn it into a standalone floating toolbar. >... Thank you for the explanation! Let's put this one to INVALID then.
-> VERIFIED However "Table" pulldown box has title. I can not understand this difference...
(In reply to baffclan from comment #7) > I can not understand this difference... Your are right, the user must not get confused by different controls used for the same workflow. The issue is tracked in bug 87239.
(In reply to Heiko Tietze from comment #8) > (In reply to baffclan from comment #7) > > I can not understand this difference... > > Your are right, the user must not get confused by different controls used > for the same workflow. The issue is tracked in bug 87239. Thanks for information!
(In reply to baffclan from comment #7) > However "Table" pulldown box has title. > I can not understand this difference... I don't think that difference is intentional. It just that the graphic grip concept which we use for the shapes popup is inherited from OOo, thus predates the text based title that we use for other popups like for color or table, which at first introduced in Go-oo and later imported into LO. (In reply to Heiko Tietze from comment #8) > Your are right, the user must not get confused by different controls used > for the same workflow. The issue is tracked in bug 87239. That bug deals with several different kinds of inconsistencies. If there's an agreement here that the shapes popup should be switched to a text title, I would suggest to reopen this bug, and set it as an enhancement to do the switch. The code change needed in this case is trivial, here are code pointers: The popup is created in ToolBarWrapper::initialize, in case the bPopupMode variable is true. The title can be retrieved using the css::ui::theWindowStateConfiguration singleton. The only thing needed is to retrieve the title, and set it to the popup. But be aware that the resource URL might be empty, so the code should be surrounded with a try-except block etc.
(In reply to Maxim Monastirsky from comment #10) > (In reply to baffclan from comment #7) > > However "Table" pulldown box has title. > > I can not understand this difference... > I don't think that difference is intentional. It just that the graphic grip > concept which we use for the shapes popup is inherited from OOo, thus > predates the text based title that we use for other popups like for color or > table, which at first introduced in Go-oo and later imported into LO. I think the difference is intentional as when you mouseover the grip the mouse cursor changes indicating that it can be dragged, which isnt present when you open up the table and color group/split buttons, as most users would never think they were draggable anyway and likely shouldnt be. > That bug deals with several different kinds of inconsistencies. If there's > an agreement here that the shapes popup should be switched to a text title, > I would suggest to reopen this bug, and set it as an enhancement to do the > switch. Left a comment in bug 87239 for what i think should be changed, but i wouldnt be in favour of adding a title label to the shape buttons as the tooltip already indicates this label for those who are unaware.
(In reply to Yousuf Philips (jay) from comment #11) > I think the difference is intentional as when you mouseover the grip the > mouse cursor changes indicating that it can be dragged, which isnt present > when you open up the table and color group/split buttons The mouse cursor can be changed also for the text based title, if we want it. There's technically no difference between those two types of titles, except that for one we draw the dots, and for the other we draw the text. Also, the change of the mouse cursor wasn't there before 5.4 (I mentioned the commit that changed it in comment 5).
(In reply to Maxim Monastirsky from comment #12) > The mouse cursor can be changed also for the text based title, if we want > it. There's technically no difference between those two types of titles, > except that for one we draw the dots, and for the other we draw the text. > Also, the change of the mouse cursor wasn't there before 5.4 (I mentioned > the commit that changed it in comment 5). Oh okay, i see it now. I thought there were gtklabel elements in the .ui files. :D