Bug 115310 - Save button should indicate that document is modified
Summary: Save button should indicate that document is modified
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice Online
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:6.1.0 target:6.0.0.4
Keywords: difficultyBeginner, easyHack, skillJavaScript
Depends on:
Blocks:
 
Reported: 2018-01-30 12:34 UTC by Pranav Kant
Modified: 2018-05-09 07:38 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pranav Kant 2018-01-30 12:34:59 UTC
The save button in the Online UI should indicate if the document opened is already saved or not - exactly how we do in desktop version (some kind of paint over the icon)

This bug is also somewhat related to Bug 104156 and code pointers are in comment4 there.
Comment 1 Emre Öztürk 2018-04-27 10:11:47 UTC
With this commit "https://gerrit.libreoffice.org/#/c/53558/" ; 'save' button changes when there is unsaved changes.
Comment 2 Commit Notification 2018-04-30 14:34:32 UTC
ozturkemre committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/online/commit/?id=c879049f1f77484317b68082fefad9b452866f20

tdf#115310 "Save button" changes while there is unsaved changes
Comment 3 Pranav Kant 2018-04-30 14:42:40 UTC
Thanks Emre for working on this. This looks as desired now.
Comment 4 Commit Notification 2018-05-09 07:38:34 UTC
ozturkemre committed a patch related to this issue.
It has been pushed to "libreoffice-6-0":

http://cgit.freedesktop.org/libreoffice/online/commit/?id=91bae92f1c1b1c4cd850de4c64cc6a6f9ea50750&h=libreoffice-6-0

tdf#115310 "Save button" changes while there is unsaved changes