Created attachment 139558 [details] *.vsd file and according *.odg file when opening a visio (*.vsd) file with LibreOffice Draw you can save this file to the Draw Format (*.odg). When I close this new file and open it again, then the following message will appear: Lesefehler. Formatfehler in Teildokument content.xml an Position 2,3473(Zeile,Spalte) in der Datei entdeckt. This error will not appear when I do the same procedure as discribed above with LibreOfficeDraw 5.3.7. All versions from 5.4.x to 6.0.x will create the above error message.
Confirmed under ubuntu 16.04 x64 with Version: 5.5.0.0.alpha0+ Build ID: 59c9d0653cc42560af48269bb8dee2c2b0b20f68 CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk2; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2017-06-06_23:50:05 Locale: en-US (en_US.UTF-8); Calc: single Unconfirmed with Version: 5.3.7.2 Build ID: 6b8ed514a9f8b44d37a1b96673cbbdd077e24059 CPU Threads: 2; OS Version: Linux 4.4; UI Render: default; VCL: gtk2; Layout Engine: new; Locale: en-US (en_US.UTF-8); Calc: single
On pc Debian x86-64 with master sources updated yesterday, I could reproduce this. Here are the corrupted blocks generated : <style:graphic-properties ="evenodd" draw:stroke="none" draw:fill="solid" draw:fill-color="#ffffcc" draw:shadow="hidden"/> <style:graphic-properties ="evenodd" draw:stroke="none" draw:fill="gradient" draw:fill-gradient-name="Gradient_5f_0" draw:shadow="hidden"/>
Regression introduced by: author Mohammed Abdul Azeem <azeemmysore@gmail.com> 2017-03-15 10:20:06 +0530 committer David Tardon <dtardon@redhat.com> 2017-03-21 09:24:32 +0000 commit 9f9e861c6d168e8318b9cdc761a387b0d650e5c0 (patch) tree 02bdb8da78c2b899a5ed9d4132ec02632490c3c2 parent d7470bab57640a4499500e3c06ace4fb8ab9c4af (diff) Old-to-new mapping of attributes is moved into a Module: This should make it easy to reuse the mapping code wherever necessary and restores the loading of writerperfect documents. Bisected with: bibisect-linux-64-5.4 Adding Cc: to Mohammed Abdul Azeem
I submitted a patch here: https://gerrit.libreoffice.org/#/c/49242/ It allows to open the odg file without error but I noticed "evenodd" parts quoted in my previous comment were lacking in the odg generated from vsd. Perhaps "svg:fill-rule" should be declared in other files like: - include/xmloff/xmltoken.hxx - xmloff/source/core/xmltoken.cxx - dtd/drawing.mod - other? ? David: I put you in cc. Indeed, since you were the reviewer of the patch quoted by Xisco, thought you might have some idea too.
Notice that when saving to otg, you'll get the same error as when saving to odg. And when saving to fodg, you'll get a "General Error. General input/output error.". All formats still worked when saving with v5.3.7.2.
*** Bug 115644 has been marked as a duplicate of this bug. ***
*** Bug 115455 has been marked as a duplicate of this bug. ***
The problem persiste in version 6.0.1.1.
Created attachment 139905 [details] Error message
*** Bug 115882 has been marked as a duplicate of this bug. ***
Created attachment 140115 [details] File generated File generated on LO built locally with the patch proposed in https://gerrit.libreoffice.org/#/c/49242/3
Julien Nabet committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=5222383c29d190218108c7c9e362a5a55af73a2f tdf#115429: declare fill-rule It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Patch for 6.0 on gerrit review here: https://gerrit.libreoffice.org/#/c/50480/
i'll try to add some asserts for that sort of thing...
Julien Nabet committed a patch related to this issue. It has been pushed to "libreoffice-6-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=4b29ee6a6a5620610de816b27dccd9c0121e49be&h=libreoffice-6-0 tdf#115429: declare fill-rule It will be available in 6.0.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=700ed27678d688b1afdb4d1759dcd4b078898a3a tdf#115429 xmloff: ODF import: fix handling of unknown attributes It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0a1d5af2a18d6a062c45d65689fbce619922dcc8 tdf#115429 sax: assert if exporting an invalid XML attribute/element It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=1bd9fcafe67cac9404c8c96553a262c048802c25 tdf#115429 sax,xmloff: assert on empty attribute names & namespaces It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
okay so Julien's patch works around the problem for the particular attribute that is generated by libvisio for this document, but the same thing could potentially happen for any other attribute that the ODF filter doesn't know yet. so i've added a more general fix to handle unknown attributes properly.
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-6-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=316501e04218e86c1e97a0fa606727d0fa989eaa&h=libreoffice-6-0 tdf#115429 xmloff: ODF import: fix handling of unknown attributes It will be available in 6.0.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-5-4": http://cgit.freedesktop.org/libreoffice/core/commit/?id=dab0220f91bcd2dab85309c14bcd10c27639544d&h=libreoffice-5-4 tdf#115429 xmloff: ODF import: fix handling of unknown attributes It will be available in 5.4.7. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-5-4-6": http://cgit.freedesktop.org/libreoffice/core/commit/?id=6bfe6822cc40a9bf3e1e237b6a0edd3dcb34de80&h=libreoffice-5-4-6 tdf#115429 xmloff: ODF import: fix handling of unknown attributes It will be available in 5.4.6. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Let's simplify a bit targets.
*** Bug 116405 has been marked as a duplicate of this bug. ***
*** Bug 116556 has been marked as a duplicate of this bug. ***
*** Bug 116728 has been marked as a duplicate of this bug. ***