Bug Hunting Session
Bug 115519 - Enhance the conditional formatting confirmation dialog
Summary: Enhance the conditional formatting confirmation dialog
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Conditional-Formatting Dialog-Msgbox
  Show dependency treegraph
 
Reported: 2018-02-07 16:16 UTC by Thomas Lendo
Modified: 2018-02-23 11:55 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
Test scenario (8.93 KB, application/vnd.oasis.opendocument.spreadsheet)
2018-02-23 11:55 UTC, Heiko Tietze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Lendo 2018-02-07 16:16:16 UTC
Steps to reproduce:
1. Click on a cell which contains condition formatting.
2. Go to Format > Conditional Formatting > Condition... (or in LO 6.1 and newer: right-click and choose "Conditional Formatting...").
3. A message box dialog appears, asking you what to do.

Actual text:

"The selected cell already contains conditional formatting. You can either edit the existing conditional format or you define a new overlapping conditional format.

Do you want to edit the existing conditional format?
[Yes] [No]"


2 issues with the actual dialog:

a) I don't understand the question "Do you want to edit the existing conditional format? [Yes] [No]" - Why should a user want to work with conditional formatting and then click at [No]? That makes no sense.

b) The text above the question says "You can either edit the existing ... or you define a new ...". That's a completely different statement and has nothing to do with the question below of it.


Suggestion:

I vote to remove the question that causes issue a).

Also I suggest to change the whole dialog. Maybe that was the original intention of it? A new question must be introduced that is based on the first sentence in the dialog (which already must be changed according to what the final, new dialog proposes to the user). 3 conditions come into my mind:

1) User wants a new conditional formatting exactly on the selected cell(s).

2) User wants to edit the existing conditional formatting on the selected cell(s).

3) User wants to edit the existing conditional formatting of the contiguous cells that contain the identical conditional formatting that exists in the selected cell(s).


Any thoughts?


Tested with Version: 6.1.0.0.alpha0+ (x64)
Build ID: b1069ea6f25daa268eb4358d5ea20094b46ef347
CPU threads: 8; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-02-06_23:49:25
Comment 1 Yousuf Philips (jay) (retired) 2018-02-07 17:52:51 UTC
Yes this dialog is annoying and i mentioned that it should be disabled using the context menu entry in gulsah's patch if the selected cell/cells have a single conditional formatting assigned.

https://gerrit.libreoffice.org/#/c/48417/

The issue boils down to whether it should insert a conditional formatting or edit a conditional formatting, so we should decide a workflow where it should or should appear.
Comment 2 Commit Notification 2018-02-16 09:37:30 UTC Comment hidden (off-topic)
Comment 3 Heiko Tietze 2018-02-16 10:44:11 UTC Comment hidden (off-topic)
Comment 4 Regina Henschel 2018-02-16 11:29:42 UTC Comment hidden (off-topic)
Comment 5 Heiko Tietze 2018-02-21 19:29:09 UTC
The issue happens only when the condition is false, if true it shows manage conditional formatting (also true for the label)

Simple and quick solution is to just get rid of the confirmation dialog as the user will see the previous made settings in the dialog.

Right solution is to rework the request for https://gerrit.libreoffice.org/#/c/48417/ that asked for three _different_ commands. We do not have delete (better "clean") and add/modify are mixed-up.

Gülsah, doesn't sound like much effort to me.
Comment 6 Gülşah Köse 2018-02-23 11:23:43 UTC
Hi again,

@Yousuf i've implemented according to your comment "It is possible that a cell/cells fall within multiple conditional formatting ranges, and if so then it should open up .uno:ConditionalFormatManagerDialog, else it should open up .uno:ConditionalFormatDialog."

if there is two or more condition on selected cell(s) open .uno:ConditionalFormatManagerDialog else open .uno:ConditionalFormatDialog is what i understand from your comment.

Is there any problem here?


(In reply to Heiko Tietze from comment #5)

> Simple and quick solution is to just get rid of the confirmation dialog as
> the user will see the previous made settings in the dialog.

This is easy to implement. 

> Right solution is to rework the request for
> https://gerrit.libreoffice.org/#/c/48417/ that asked for three _different_
> commands. We do not have delete (better "clean") and add/modify are mixed-up.
> 

But i don't understand the right solution. Please write the scenario with more detail. I'll fix it.
Comment 7 Heiko Tietze 2018-02-23 11:55:53 UTC
Created attachment 140086 [details]
Test scenario

(In reply to Gülşah Köse from comment #6)
> But i don't understand the right solution. Please write the scenario with
> more detail. I'll fix it.

Sure, with pleasure.

(In reply to Yousuf Philips (jay) (retired) from comment #0)
> 1) Edit Conditional Formatting... - Shown when right-click on a single cell
> or a group of cells that all part of the same conditional formatting data
> range.
> 
> 2) Delete Conditional Formatting - Appears whenever the edit entry appears
> and makes it easy to delete a conditional formatting range.
> 
> 3) Manage Conditional Formatting... - Shown when right-clicking on a range
> of cells that contain one or more conditional formatting data ranges in it.

The attached example has three columns, the first with no conditional formatting (and no context menu entry), the second with one CF of "if <3 then bad else if >3 then good", and on the third column it's split into c2..c3 with "if <3 then bad" and c5..c6 "if >3 then good". 

The context menu should show "Conditional Formatting..." for col B, whether one cell is selected or a range with the same CF - and start the dialog without confirmation (also when you select B7, ie. a cell with no cf). And according Jay's request #3 it should be "Manage Conditional Formatting.." for col C with varying conditions.

If testing ranges for similar CF is too much effort you can also go with "Manage CF" when more than one cell is selected (what was actually the request).