Bug 115520 - Define Database Range shouldn't close after having a false name
Summary: Define Database Range shouldn't close after having a false name
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Tünde Tóth
URL:
Whiteboard: target:7.3.0 target:7.2.1
Keywords:
Depends on:
Blocks: Calc-DataRange
  Show dependency treegraph
 
Reported: 2018-02-07 16:29 UTC by Thomas Lendo
Modified: 2021-09-08 10:14 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Lendo 2018-02-07 16:29:48 UTC
Steps to reproduce:
1. Open a Calc spreadsheet.
2. Go to Data > Define Range...
3. In the Define Database Range dialog, type "a1" in the "Name" textfield.
4. Click OK or type Enter.
5. A dialog appears without a dialog name with text "Invalid name." and an OK button.
6. Click OK.

Actual result:
The Define Database Range dialog will be closed too.

Expected result:
User is back in the Define Database Range dialog and can choose another name that is right.


Side note: Has the invalid name dialog the correct appearance?
Comment 1 Heiko Tietze 2018-02-15 23:36:28 UTC
Fully agree. Ideally, the Ok button is disabled when a bane is entered that cannot be used (apparently cell names or numbers). But definitely the dialog must not disappear.
Comment 2 Thomas Lendo 2018-02-16 09:10:52 UTC
The OK button could be disabled, right, but then we need a visual feedback for the user why OK can't be clicked.
Comment 3 QA Administrators 2019-02-17 03:44:29 UTC Comment hidden (obsolete)
Comment 4 QA Administrators 2021-02-17 04:13:56 UTC Comment hidden (obsolete)
Comment 5 lol 2021-03-08 14:01:40 UTC
This bug is still present in

Version: 7.0.4.2 (x64)
Build ID: dcf040e67528d9187c66b2379df5ea4407429775
CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded
Comment 6 Commit Notification 2021-08-02 19:20:21 UTC
Tünde Tóth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a07351e8181353c0c0b6df5d2ccbad4615c6706b

tdf#115520 sc UI: Define Database Range dialog disappeared

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2021-08-09 19:57:26 UTC
Tünde Tóth committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/d366fc7861a4226d053beb4b21ba665d7c7660f5

tdf#115520 sc UI: Define Database Range dialog disappeared

It will be available in 7.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 NISZ LibreOffice Team 2021-09-08 10:14:12 UTC
Verified in:
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 8151f3a1d99ab740d2affdccc7115faa156bf3ad
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: threaded