Bug 115688 - Add Checkbox option to disable animated overlay to Tools -> Options -> Accessibility panel
Summary: Add Checkbox option to disable animated overlay to Tools -> Options -> Access...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
4.2.0.4 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard: target:25.2.0
Keywords: accessibility
Depends on:
Blocks: a11y, Accessibility
  Show dependency treegraph
 
Reported: 2018-02-13 16:29 UTC by V Stuart Foote
Modified: 2024-08-30 11:55 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description V Stuart Foote 2018-02-13 16:29:58 UTC
For use with remote display, commit [1] provided Expert Configuration variable "AnimationsEnabled" to disable/enable the "animated" ScOverlayDashedBorder in Calc.

It also happened to solve an a11y issue of bug 35077. But to be more obvious it now needs a separate CheckBox control on the Tools -> Options -> Accessibility panel.

=-ref-=
[1] https://cgit.freedesktop.org/libreoffice/core/commit/?id=2e293978d80c5113ea37f4c7f4b18ee01f2022e1
Comment 1 V Stuart Foote 2018-02-13 16:40:57 UTC
@Tomaž, *

The Expert Configuration setting is good, but could we also provide a UI checkbox to control this for the benefit of users with vision issues? Grouping it with the other Assistive Technology tools controls on the Accessibility panel would ensure those who need it can find it.
Comment 2 Heiko Tietze 2018-02-13 17:17:41 UTC
I'm against this option on a prominent position (=> WFM). My arguments are in bug 35077 comment 35. The feature itself supports a11y and disabling it contradicts the original intention.
Comment 3 V Stuart Foote 2018-02-13 18:21:47 UTC
(In reply to Heiko Tietze from comment #2)
>...  The feature itself supports a11y and disabling it
> contradicts the original intention.

We are not looking to reverse the default enabled mode as that is better UX in general.

Rather the whole point to the Tools -> Options -> Accessibility panel remains to make configuration as painless as possible for those users requiring Assistive Technology support. For those with photosensitivity to visual stimuli, or full PSE, even the ~2Hz "dance" of the border animation can be disabling.

So it is _not_ a question of "promoting" to Tools -> Options, but of specifically grouping it with the other a11y AT tools to control the UI. It just makes sense to do so as it _belongs_ there.
Comment 4 Tomaz Vajngerl 2018-02-13 21:22:41 UTC
Sure, adding this to the Accessibility panel makes sense (looking at what is available there already).
Comment 5 crxssi 2018-02-13 22:11:41 UTC
I will add my hat in the ring that it SHOULD be added to accessibility options.  It isn't just for photosensitive, but also for people with OCD who are mildly to severely distracted by animation.  Of course, they can use the expert config option, but that is pretty well hidden there.
Comment 6 QA Administrators 2019-02-15 03:47:11 UTC Comment hidden (obsolete)
Comment 7 crxssi 2019-02-15 04:20:34 UTC
(In reply to QA Administrators from comment #6)
> QA is asking bug reporters and confirmers to retest open,
> confirmed bugs which have not been touched for over a year.

There is nothing to test.  As far as I am aware, the option still doesn't exist and we are still waiting...
Comment 8 V Stuart Foote 2019-02-15 13:06:38 UTC
Still valid
Comment 9 QA Administrators 2021-02-15 04:07:46 UTC Comment hidden (obsolete)
Comment 10 QA Administrators 2023-02-16 03:25:47 UTC Comment hidden (obsolete)
Comment 11 crxssi 2023-02-16 03:50:29 UTC
Still valid and still waiting.

Almost 12 years now, for a logical and user-friendly way to present an important accessibility option to the users.
Comment 12 V Stuart Foote 2023-02-16 05:40:50 UTC
(In reply to QA Administrators from comment #10)
still valid, no Tools -> Options -> Accessibility option for toggling off the "AnimationsEnabled" settings. Still requires use of Expert Configuration to toggle to boolean.
Comment 13 Heiko Tietze 2023-07-21 10:24:50 UTC
*** Bug 155414 has been marked as a duplicate of this bug. ***
Comment 14 Michael Weghorn 2023-07-21 12:19:58 UTC
(In reply to Heiko Tietze from comment #13)
> *** Bug 155414 has been marked as a duplicate of this bug. ***

Bug 155414 mentions that there are is an OS/desktop environment setting to disable animations/reduce motions for all major platforms, which is used e.g. by browsers to reduce animation automatically, s. also the MDN doc here:
https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-reduced-motion

I think it would be a good idea to also disable the "marching ants" in LibreOffice by default when that setting is enabled in the system, which *might* also make it unnecessary/less necessary to have the existing option in the Accessibility section of the settings (assuming that people who don't want that animation for a11y reasons would switch animations off on the system level).

Without yet knowing that such an expert option already existed Bug 155414 comment 2 mentions:

> One idea might be to add another option there to reduce motion/animations and
> give it three possible values (similar to the Light/Dark theme setting in the
> "View" section [NOTE: it's actually in "Application Colors"]: enable/disable/automatic, where "automatic" (the
> default?) would use the value from the OS/desktop environment. And
> if that setting is enabled, avoid animations like the one mentioned
> here.

Now that we already have boolean option "AnimationsEnabled" and this ticket to request making it visible in the UI, I'm wondering what would be the best way to move forward.

I think for compatibility reasons, we won't be able to change the existing boolean option to allow more values (so enable/disable/automatic won't work with that one), so 2 possible ways to achieve something like this might be:

1) add a new option that allows 3 values enable/disable/"automatic/System" and deprecate/ignore the old one

2) introduce a new one, "AnimationsEnabledOverrideSystemDefault" or somesuch (defaulting to false), and only if that is set in addition, the value of "AnimationsEnabled" is taken into account, otherwise whether animations are enabled follows the system default.

Any thoughts on whether this would be a good idea and whether that would make it unnecessary to have the option elsewhere in the UI in addition to the expert configuration?
Comment 15 crxssi 2023-07-21 12:57:26 UTC
(In reply to Michael Weghorn from comment #14)

> Any thoughts on whether this would be a good idea and whether that would
> make it unnecessary to have the option elsewhere in the UI in addition to
> the expert configuration?

The purpose of exposing the control in the UI is to give the average user a quick and easy way to turn off animations without doing lots of research in their OS *or* in LibreOffice.  Or maybe the OS/DE/System doesn't support it (Linux with Cinnamon or IceWM or XFCE are just a few examples).  So I think that is needed, regardless.

I think there should be a UI toggle.  It is then tied to the LO advanced config setting always.  Either one toggles the other, always.

If the OS/DE/System level has animations disabled set, LO should just honor that always, automatically, and the UI then shows it set, grays out they selection (disables changing it), and prevents or ignores changes to the LO config.

I say this because it is highly unlikely that anyone who has animations disable/reduced set at the OS/DE/system level (if that is even a choice) will ever want to manually override that to turn animations ON in just LO.

This maintains having only one LO Config setting, and backwards-compatibility, while also honoring the sometimes-present DE/OS/System-level setting.
Comment 16 Michael Weghorn 2023-07-22 04:36:24 UTC
(In reply to crxssi from comment #15)
> If the OS/DE/System level has animations disabled set, LO should just honor
> that always, automatically, [...], and prevents or ignores changes to the LO
> config.
> 
> I say this because it is highly unlikely that anyone who has animations
> disable/reduced set at the OS/DE/system level (if that is even a choice)
> will ever want to manually override that to turn animations ON in just LO.
> 
> This maintains having only one LO Config setting, and
> backwards-compatibility, while also honoring the sometimes-present
> DE/OS/System-level setting.

That (leaving out the UI part for now) fits with Patrick's suggestion on how to handle the OS/DE/System setting in tdf#155414 comment 7 and sounds reasonable to me.
Comment 17 Commit Notification 2024-07-31 07:30:01 UTC
Per99 committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ef7429f86788f0616db5b274ec77eb67cd41cb3d

tdf#161765, tdf#115688 Let user choose which animation settings to use

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 18 Michael Weghorn 2024-08-30 11:55:53 UTC
This was implemented in the commit from comment 17, which added the "Allow other animations" option to the accessibility options page.

-> Closing as fixed