Bug 115908 - test_text_direction failures because the xTextDirectionList dropdown is not visible by default
Summary: test_text_direction failures because the xTextDirectionList dropdown is not v...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha0+
Hardware: All Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-21 13:38 UTC by Olivier Tilloy
Modified: 2018-02-22 20:30 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Tilloy 2018-02-21 13:38:31 UTC
Description:
The ubuntu packages for libreoffice run UI tests as part of their autopkgtest test suite. Since the update to 6.0, the test_text_direction test has been consistently failing (see https://launchpad.net/bugs/1750335).

While investigating the failure, I put a breakpoint in the test and observed that the xTextDirectionList dropdown is not visible, which explains why the test can't select another text direction. Indeed, when running the application and opening the page dialog, that dropdown is hidden by default, until one checks the "Asian" checkbox in the Language Settings.

I guess a prerequisite for the test_text_direction test is to make sure that the correct language settings are enabled.

Steps to Reproduce:
Run uitest

Actual Results:  
failures on test_text_direction

Expected Results:
all tests pass


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/65.0.3325.73 Chrome/65.0.3325.73 Safari/537.36
Comment 1 raal 2018-02-21 15:38:58 UTC
Xisco,please take a look.

/core/uitest/writer_tests/pageDialog.py
Comment 3 Olivier Tilloy 2018-02-22 08:05:09 UTC
> https://salsa.debian.org/libreoffice-team/libreoffice/libreoffice/commit/ef1bd99104bb40e1605ceee9ec336456c2a5d74d
> 
> fixed that for me, hasn't failed ever since

That commit was backported to the ubuntu package, but that didn't seem to improve the situation.
Comment 4 Rene Engelhard 2018-02-22 08:08:59 UTC
Because your l10n hacks are creating incomplete packages?

$ dpkg -L libreoffice-l10n-he
/.
/usr
/usr/lib
/usr/lib/libreoffice
/usr/lib/libreoffice/program
/usr/lib/libreoffice/program/resource
/usr/lib/libreoffice/program/resource/he
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/acc.mo
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/avmedia.mo
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/basctl.mo
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/chart.mo
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/cnr.mo
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/cui.mo
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/dba.mo
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/dkt.mo
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/editeng.mo
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/flt.mo
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/for.mo
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/fps.mo
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/frm.mo
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/fwk.mo
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/pcr.mo
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/rpt.mo
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/sb.mo
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/sc.mo
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/sca.mo
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/scc.mo
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/sd.mo
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/sfx.mo
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/sm.mo
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/svl.mo
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/svt.mo
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/svx.mo
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/sw.mo
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/uui.mo
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/vcl.mo
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/wiz.mo
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/wpt.mo
/usr/lib/libreoffice/program/resource/he/LC_MESSAGES/xsc.mo
/usr/lib/libreoffice/share
/usr/lib/libreoffice/share/autotext
/usr/lib/libreoffice/share/autotext/he
/usr/lib/libreoffice/share/registry
/usr/lib/libreoffice/share/registry/Langpack-he.xcd
/usr/lib/libreoffice/share/registry/ctl_he.xcd
/usr/lib/libreoffice/share/registry/res
/usr/lib/libreoffice/share/registry/res/fcfg_langpack_he.xcd
/usr/lib/libreoffice/share/registry/res/registry_he.xcd
/usr/lib/libreoffice/share/template
/usr/lib/libreoffice/share/template/he
/usr/lib/libreoffice/share/template/he/presnt
/usr/lib/libreoffice/share/wordbook
/usr/lib/libreoffice/share/wordbook/he
/usr/lib/libreoffice/share/wordbook/he/technical.dic
/usr/share
/usr/share/bug
/usr/share/bug/libreoffice-l10n-he
/usr/share/bug/libreoffice-l10n-he/presubj
/usr/share/doc
/usr/lib/libreoffice/share/template/he/presnt/debian-presentation.otp
/usr/share/doc/libreoffice-l10n-he
$

now compare this with

https://packages.ubuntu.com/bionic/all/libreoffice-l10n-he/filelist.

I see (at least) /usr/lib/libreoffice/share/registry/ctl_he.xcd missing on a first glance.
Comment 5 Olivier Tilloy 2018-02-22 08:50:43 UTC
Indeed, /usr/lib/libreoffice/share/registry/ctl_he.xcd is in the debian package but not in the ubuntu one. It looks like it's the only missing file.
Comment 6 Rene Engelhard 2018-02-22 09:09:35 UTC
$ cat /usr/lib/libreoffice/share/registry/ctl_he.xcd
<?xml version="1.0"?>
<oor:data xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:oor="http://openoffice.org/2001/registry"><dependency file="main"/><oor:component-data xmlns:install="http://openoffice.org/2004/installation" oor:name="Common" oor:package="org.openoffice.Office"><node oor:name="I18N"><node oor:name="CTL"><prop oor:name="CTLFont"><value>true</value></prop></node></node></oor:component-data></oor:data>

doesn't immediately say something about text direction, though..
Comment 7 Olivier Tilloy 2018-02-22 09:38:22 UTC
I have manually installed the missing files (ctl_he.xcd and cjk_ja.xcd) and the autopkgtests pass. So this is clearly not a libreoffice issue. Not sure how to mark this as NOTABUG though.
Comment 8 Rene Engelhard 2018-02-22 09:42:22 UTC
there's a NOTABUG (and also a NOTOURBUG)
Comment 9 Rico Tzschichholz 2018-02-22 14:33:16 UTC
The make targets "install-package-l10n-$LANG" fail to install those files.

https://gerrit.libreoffice.org/#/c/50181/1