Bug 115921 - [EDITING, REGRESSION] Crash when drawing line / arrow in LOMaster
Summary: [EDITING, REGRESSION] Crash when drawing line / arrow in LOMaster
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
6.1.0.0.alpha0+
Hardware: All All
: highest critical
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, haveBacktrace, regression
: 115922 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-02-21 19:59 UTC by Tobias Burnus
Modified: 2018-02-21 20:49 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Burnus 2018-02-21 19:59:21 UTC 
If one tries to draw a line or arrow (e.g. by clicking the symbol), LO master immediately crashes as soon as one presses the left mouse key.

(Happens in Writer, Draw, Impress, ...)

LO 6.0 works, but in LO 6.1/Master it crashes since at least a few weeks. Tested with:

Version: 6.1.0.0.alpha0+
Build ID: ea360461746f37be021b63da7a64a60d0f3c4af4
CPU threads: 4; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-02-21_02:14:22
Locale: en-US (en_US); Calc: CL
Comment 1 Julien Nabet 2018-02-21 20:09:21 UTC 
*** Bug 115922 has been marked as a duplicate of this bug. ***
Comment 2 Julien Nabet 2018-02-21 20:09:59 UTC 
Confirmed by duplicate
See https://bugs.documentfoundation.org/attachment.cgi?id=140044 for bt.
Comment 3 Julien Nabet 2018-02-21 20:21:02 UTC 
On pc Debian x86-64 with master sources updated today, I could reproduce this.
Here's a part of bt with symbols.

#4  0x00007fffef8e227c in XPolygon::operator[](unsigned short) (this=0x55555878f320, nPos=0) at /home/julien/lo/libreoffice/svx/source/xoutdev/_xpoly.cxx:257
#5  0x00007fffef5e98a3 in ImpPathForDragAndCreate::BegCreate(SdrDragStat&) (this=0x55555c2075f0, rStat=...) at /home/julien/lo/libreoffice/svx/source/svdraw/svdopath.cxx:1245
#6  0x00007fffef5ee07b in SdrPathObj::BegCreate(SdrDragStat&) (this=0x55555c20a7c0, rStat=...) at /home/julien/lo/libreoffice/svx/source/svdraw/svdopath.cxx:2195
#7  0x00007fffef4854c1 in SdrCreateView::ImpBegCreateObj(SdrInventor, unsigned short, Point const&, OutputDevice*, short, tools::Rectangle const&, SdrObject*) (this=
    0x555557a114c0, nInvent=SdrInventor::Default, nIdent=2, rPnt=Point = {...}, pOut=0x0, nMinMov=90, rLogRect=..., pPreparedFactoryObject=0x0)
    at /home/julien/lo/libreoffice/svx/source/svdraw/svdcrtv.cxx:492
#8  0x00007fffef4856a7 in SdrCreateView::BegCreateObj(Point const&, OutputDevice*, short) (this=0x555557a114c0, rPnt=Point = {...}, pOut=0x0, nMinMov=90)
    at /home/julien/lo/libreoffice/svx/source/svdraw/svdcrtv.cxx:511
#9  0x00007fffc9a48304 in sd::FuConstructRectangle::MouseButtonDown(MouseEvent const&) (this=0x5555587c5830, rMEvt=...)
    at /home/julien/lo/libreoffice/sd/source/ui/func/fuconrec.cxx:198
Comment 4 Julien Nabet 2018-02-21 20:22:26 UTC 
I think it's fixed with https://cgit.freedesktop.org/libreoffice/core/commit/?id=e07d741b61ddc8b13046ce6ea0c0921ce046a0cf, I'm giving it a try locally.
Comment 5 Xisco Faulí 2018-02-21 20:49:50 UTC 
Regression introduced by:

author	Noel Grandin <noel.grandin@collabora.co.uk>	2018-02-05 15:56:12 +0200
committer	Noel Grandin <noel.grandin@collabora.co.uk>	2018-02-06 12:47:32 +0100
commit f9c2bcc8b761f5e21354c0fb7bca6aa432d11ec2 (patch)
tree a40dbc3e6d1b7476ad93cee29f19590103c4e756
parent e1f479af4ddde90f9e80b5079ac759cb9f7743a1 (diff)
simplify ImpXPolygon

and reverted in https://cgit.freedesktop.org/libreoffice/core/commit/?id=e07d741b61ddc8b13046ce6ea0c0921ce046a0cf.

@Noel, please, take this bug into account if a second patch is submitted to master