Created attachment 140053 [details] Excel File in question Hi There, I currently have a password protected Excel file with the XLSX extension, this file allows read only mode and Read and Write if the password is provided. The issue is if this file is opened using Librecalc no password is required , and the user is able to edit this same file. Is there any solution to overcome this problem ?
Hello Bene, This is happening because it's a blank password. Could you please try to set a minimal password and re-test? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the issue is still present
Hi Fauli The file does not have a blank password, if you execute the XLSX doc in Excel you will be prompted for a password, and in Librecalc the password is bypassed. don`t understand why the blank password statement Did you had the chance to have a look at the file ?
(In reply to Bene from comment #2) > Hi Fauli > > The file does not have a blank password, if you execute the XLSX doc in > Excel you will be prompted for a password, and in Librecalc the password is > bypassed. don`t understand why the blank password statement > > Did you had the chance to have a look at the file ? Yes, in MSO 2010, when the file is open the password dialog is prompted, pressing Enter displays the file, meaning the password is blanked. The bug here is that LibreOffice should at least display the password dialog
(In reply to Xisco Faulí from comment #3) > Yes, in MSO 2010, when the file is open the password dialog is prompted, > pressing Enter displays the file, meaning the password is blanked. > Hmm... AFAICS, the password prompt dialog in MSO (2016) has the OK button disabled, and Read Only set to default, until something is entered into the box. Enter just executes the default action (read-only).
(In reply to Mike Kaganski from comment #4) > (In reply to Xisco Faulí from comment #3) > > Yes, in MSO 2010, when the file is open the password dialog is prompted, > > pressing Enter displays the file, meaning the password is blanked. > > > > Hmm... AFAICS, the password prompt dialog in MSO (2016) has the OK button > disabled, and Read Only set to default, until something is entered into the > box. Enter just executes the default action (read-only). Ouch, you're right! My bad!! Closing as RESOLVED DUPLICATED of bug 104250 *** This bug has been marked as a duplicate of bug 104250 ***
There is no clear answer to this , how do we stand ? In my opinion this is a Bug with Libreoffice there is no blank password on this file
(In reply to Bene from comment #6) > There is no clear answer to this , how do we stand ? In my opinion this is a > Bug with Libreoffice there is no blank password on this file Yes it's a bug. I was wrong when I said the password was blanked. This bug has already been reported in bug 104250 *** This bug has been marked as a duplicate of bug 104250 ***
Thanks Is there any workaround , or plan to fix this bug. The other post dates back to 2016... where this issue was reported and identified as a Bug. Libre developers are no interested in sorting this issue ?
(In reply to Bene from comment #8) > Thanks > > Is there any workaround , or plan to fix this bug. The other post dates back > to 2016... where this issue was reported and identified as a Bug. Libre > developers are no interested in sorting this issue ? Hello Bene, it seems today is your lucky day. Eike ( our Calc expert ) is investigating it -> https://bugs.documentfoundation.org/show_bug.cgi?id=104250#c13
This is not a duplicate, though similar or related. Bug 104250 is about the <sheetProtection> element, whereas this is about the <fileSharing> element. This will need to support the <fileSharing> element with algorithmName, hashValue, saltValue and spinCount attributes and feed those with the password to be entered to the proper hashing/digest implementation. Currently only the reservationPassword hash and readOnlyRecommended attributes are supported, which are not present here. If reservationPassword hash or readOnlyRecommended=true were present, the document would always be opened read-only. A password dialogue unprotected write open is not implemented.
Eike Rathke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0fe1b2fb823470e2f5eae574f9c9f877eecc932d Read algorithmName, hashValue, saltValue, spinCount, tdf#115933 prep It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Eike Rathke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=2d5a9e9f26daf95f33afb0d28ffd088cdd41ae8c tdf#115933 set document read-only on presence of hashValue attribute It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
With those commits an xlsx document opens read-only on presence of a <fileSharing> hashValue attribute with content. Currently there's no way to enter edit mode for such document other than saving to a different file. Unassigning myself now to free this up for someone to take over for the "dialogue to edit" part. If the unconditional read-only is sufficient we can backport the commits to 6-0 if wanted and/or set the bug resolved fixed.
This report is subset of bug 89383. bug 118938 is the filesave version of this request.
Tünde Tóth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/40f38fd16dad4374543d4a7a109b3264837ce8d1 tdf#115933 XLSX import: fix permission for editing It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified in: Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: c2de581d1943df2d84f2b71817b6a8bee41f0217 CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win Locale: hu-HU (hu_HU); UI: hu-HU Calc: CL