Bug 116231 - admin-console: no indication when wsd shuts down
Summary: admin-console: no indication when wsd shuts down
Status: NEW
Alias: None
Product: LibreOffice Online
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyBeginner, easyHack, skillJavaScript
Depends on:
Blocks: LOOL-Admin-Console
  Show dependency treegraph
 
Reported: 2018-03-06 12:04 UTC by Pranav Kant
Modified: 2019-02-03 05:33 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pranav Kant 2018-03-06 12:04:51 UTC
While wsd is running, open the admin console

Now Ctrl + C to stop the wsd process. The admin console should show the user that Online was shut down. Worse, when the wsd is restarted, the admin-console screen is not updated accordingly; it keeps showing the stale view from the previous launch.

An error box or the overlay saying that wsd has been shut down sounds good to me which refreshes the page with the new WS connection whenever user clicks on the overlay. THis is similar to when the document becomes inactive after 5 minutes or so.

how to hack:
Check what web socket messages we receive when wsd shuts down in the backend and handle it appropriately in the admin websocket. One can check the websocket handling for the documents in src/core/Socket.js and do something similar with the admin websocket. Code for admin websocket is in loleaflet/src/admin/