By Tools -> Options -> LibreOffice -> Application Colours you can choose a colour for AutoSpellCheck. This applies to the wavy line below the word with the incorrect spelling, but not to the character colour of the same word in the spelling dialog opened via Tools -> Spelling... For people with visual impairment who choose a dark document background an bright colours for text this is a problem. The character colour in the dialog should therefore be changed to the same colour as the wavy line. Remark: bugs #95684 and #105527 have a connected issue, but do not deal with the same problem, they are rather more general.
I think this would only be useful, if the background of the spelling dialog is also dark. But is this possible?
Yes, if the background colour for documents is changed, it is changed for the dialog, too. Otherwise it would indeed be nonsense to ask for the change of the chararacter colour.
If I change the document background colour or the application background colour the background of the spelling dialog is still white.
Would say yes as there are more reasons to adjust the color than for dark backgrounds. On the other hand, the dialog has a slightly different identification by bold and colored single word instead of wavy underline and colored multiple words. Other opinions?
Dieter Praas was right in asking if the background of the field in the dialog could be dark. I would have sworn that it had changed when I changed the document background colour (see comment #2), but I cannot reproduce it, so I must admit that I probably beguiled myself. B u t it can be changed when choosing a high contrast theme, as I was informed by Regina and the person who inspired my bug report. In Windows 10 there are 3 (of 4) high contrast themes that use a black background. A person that chooses one of these will very probably also choose a dark, although not necessarily black, background for the documents, as did indeed my informant. Then he will choose a light colour for the wavy line below the error in the document, and the same colour would be certainly more appropriate in the spelling dialog than the original red colour which does not provide much contrast to the dark background.
No one disagreed, so please implement the change as suggested and respect background and foreground colors as configured by the user.
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
No change as regards version 6.2.2.2.
Still present in Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 15a9bee9ef26ce13ed1e26319306a88b6d886158 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL Steps to reproduce 1. Open Tools => Options => LibreOffice => Application Colours 2. Change colour for AutoSpell Check (for example change it to Dark Purple 1) 3. Write some word with a wrong spelling => wrong words are underline in Dark Purple 1 (expected) 4. Tools => Spelling Actual result: Word with wrong spelling doesn't have Dark Purple as colour Expected result: Should have.
Changing the application color has no immediate effect, all currently red-lined content remain red. But new typos take the color (haven't checked what happens after load/save).
Created attachment 183181 [details] Current state of dark mode in the Spelling dialog Here's the current state of the Spelling dialog using dark mode. I changed the AutoSpellCheck color to purple and it does not have an effect on the dialog. Moreover, the preview is black whereas my Document Color is white. So what I propose is: 1) Use the Document Color / Font Color options in the preview box 2) Respect the AutoSpellCheck color for the highlighted text I'll see if I can do it and then submit a patch.
Patch available for review at: https://gerrit.libreoffice.org/c/core/+/142147
Rafael Lima committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1de8308d40fad8e9281d2b491f8c5c919fda82f4 tdf#116566 Make Spellcheck dialog respect dark background It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
VERIFIED with Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 55cd20e6228a06836285c14ca6726adb1bb4ffcb CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: en-US (de_DE); UI: en-GB Calc: CL threaded Rafael, thanks for fixing it!
Rafael Lima committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/9adcf14d9b2e9dffd47a26eae202da348675a5e4 tdf#116566 Make Spellcheck dialog respect dark background It will be available in 7.4.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
7.4.5 was a hotfix release, updating target in status-whiteboard