Bug 116699 - Add option "Protect manual changes (of content) against updating of index"
Summary: Add option "Protect manual changes (of content) against updating of index"
Status: RESOLVED WONTFIX
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: TableofContents-Indexes
  Show dependency treegraph
 
Reported: 2018-03-29 19:56 UTC by Tyco72
Modified: 2018-04-04 18:37 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tyco72 2018-03-29 19:56:42 UTC
Description:
Text changes (manually) on table of contents are not saved.
The bug was present at least also in LO 5.2

Steps to Reproduce:
1) create a table of contents in Writer (Menu "Insert" > "Tables of contents and index" > "Tables of contents")
2) In the properties disable the flag "Protect to manual modifications"
3) Create some entries, e.g.:
"Paragraph xxx……...1"
4) In the document change manually the text of the index, eg, change to:
"Paragraph yyy…….1"
5) Right click on the table of content and select "Udate index".
The text returns to the original text ""Paragraph xxx……...1" the changes are lost

The bug was present at least also in LO 5.2

Actual Results:  
The text returns to the original text ""Paragraph xxx……...1" the changes are lost

Expected Results:
The text manually changed should be overtaken.


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
Comment 1 Dieter 2018-03-30 05:11:23 UTC
(In reply to btv2000 from comment #0)
> Expected Results:
> The text manually changed should be overtaken.

So your idea is that "update index" only updates the page numbers?
Comment 2 Tyco72 2018-03-30 09:19:14 UTC
No. I mean that when you change a text directly in the index, it should be also directly saved. Then when you press "update index", your changed text is kept.
Otherwise, what's the point to disable the option "Protect to manual modifications"?

It is much more quick and comfortably to change the texts directly in the table, instead of to go to each marked point in the document, then right click -> index entry, and change the text in the box there. This you have to do for each entry you need to change. When you have an index with many entries it is takes a lot of work.
Comment 3 Dieter 2018-03-30 10:24:36 UTC
(In reply to btv2000 from comment #2)
> No. I mean that when you change a text directly in the index, it should be
> also directly saved.

I don't understand. If you change a text directly in the index, it is a text formatting, which is handled like any other text formatting - you have to save it.

And even if it is saved, "update index" actually will overwrite your formatting. So my question is still: What should happen, if you select "update index"?
Comment 4 Buovjaga 2018-04-02 17:10:57 UTC
It does not say "Protect manual changes against updating of index".
Comment 5 Dieter 2018-04-02 17:22:43 UTC
(In reply to Buovjaga from comment #4)
> It does not say "Protect manual changes against updating of index".

Such an option would be a good enhancement. Would such an option solve your problem, btv2000?
Comment 6 Tyco72 2018-04-02 21:07:16 UTC
@Dieter Praas (Comment #5)
It is a good idea. It should solve the problem. Of course it should affect only the text description. The page number should get updated, if the position of the marked points in document has been moved.

In general, I don't understand what's the point to allow you to change manually the text, if you can't keep it. When you manually change a text entry in the index, I would expect that it replaces permanently the old text and you don't loose it when you update the index.
Comment 7 Heiko Tietze 2018-04-03 08:00:00 UTC
In my opinion that's a WONTFIX. Let's say you create heading one, two, three and edit the ToC, to uppercase for example. What should happen when you delete the second heading? Keep the first letter in an extra line?

I would rather go the other way and disable the manual editing completely. The help is also not informative with "This protection is not intended to be a secure protection. It is just a switch to protect the contents against accidental changes.", which is not a use case for me.
https://help.libreoffice.org/Writer/Protecting_Content_in_Writer
Comment 8 Dieter 2018-04-03 08:18:27 UTC
Heiko, I disagree. From my experience there are some occasions, where it is very comfortable to change the formatting manually. For example to add a line break, reduce the spacing of one paragraph, so that the headings of one chapter fits in one page, ...) For the basic formatting I use paragraph styles.

So perhaps this examples make it more clear what - in my view - manual changes are about. I wouldn't delete a heading or change a page number manually.
Comment 9 Heiko Tietze 2018-04-03 08:24:15 UTC
(In reply to Dieter Praas from comment #8)
> ... add a line break, reduce the spacing of one paragraph...

Perfect examples why direct formatting is bad. ;-)

But let's talk about the horizontal ruler added between heading 2 and 3 to separate the two chapters in the ToC. What happens when the structure changes - keep the HR between 2-3 or move it to 3-4 if another 2 has been added or remove it if 2 or 3 got deleted?
Comment 10 Buovjaga 2018-04-03 09:42:11 UTC
(In reply to Dieter Praas from comment #8)
> Heiko, I disagree. From my experience there are some occasions, where it is
> very comfortable to change the formatting manually. For example to add a
> line break, reduce the spacing of one paragraph, so that the headings of one
> chapter fits in one page, ...) For the basic formatting I use paragraph
> styles.
> 
> So perhaps this examples make it more clear what - in my view - manual
> changes are about. I wouldn't delete a heading or change a page number
> manually.

If there are cases where manual formatting is needed, it is telling us that the parametric formatting is lacking somehow.

I agree with Heiko that the option to manually do changes should be removed. Any shortcomings in the parametric formatting should be filed as bug/enhancement reports.
Comment 11 Tyco72 2018-04-03 18:50:26 UTC
I am not talking about to change the formatting, like the position of rows or add spaces between rows. I am talking only about the description texts.
As told, when you have table of content with many rows to edit, it is a very uncomfortable work and it requires many clicks more, to change the texts jumping to each marked point and then right click, etc... I think that any common user would found it better.
Comment 12 Buovjaga 2018-04-04 08:49:57 UTC
(In reply to btv2000 from comment #11)
> I am not talking about to change the formatting, like the position of rows
> or add spaces between rows. I am talking only about the description texts.
> As told, when you have table of content with many rows to edit, it is a very
> uncomfortable work and it requires many clicks more, to change the texts
> jumping to each marked point and then right click, etc... I think that any
> common user would found it better.

This is not very convincing. With the use of the right tools, like Navigator to do the jumping, it is not a lot of work.
Comment 13 Dieter 2018-04-04 09:25:02 UTC
(In reply to Heiko Tietze from comment #9)
> (In reply to Dieter Praas from comment #8)
> > ... add a line break, reduce the spacing of one paragraph...
> 
> Perfect examples why direct formatting is bad. ;-)

Why?


> But let's talk about the horizontal ruler added between heading 2 and 3 to
> separate the two chapters in the ToC. What happens when the structure
> changes - keep the HR between 2-3 or move it to 3-4 if another 2 has been
> added or remove it if 2 or 3 got deleted?

Can't answer the question, because I don't know nothing about a horizontal ruler between two headings.
Comment 14 Heiko Tietze 2018-04-04 18:14:23 UTC
Closing as WONTFIX as there is no support for this idea. The navigator offers access to the headings (admittedly with room for improvement) and editing the ToC is not a use case.

Thanks for filing the report anyway. We keep it in mind.
Comment 15 Thomas Lendo 2018-04-04 18:37:47 UTC
(In reply to Buovjaga from comment #10)
> I agree with Heiko that the option to manually do changes should be removed.
> Any shortcomings in the parametric formatting should be filed as
> bug/enhancement reports.
Just for the record, please do NOT remove the option to change an index manually. It is an option the user must activate by himself, so there is no confusion. I use this option very often for example for temporary changes for printouts. This option and the fact that manual changes are saved with the document and not automatically deleted when reopening a file is a superior feature in comparison to MSO Word.