Bug 116791 - dialog.dtd:245:61: fatal: character not allowed when converting with trang
Summary: dialog.dtd:245:61: fatal: character not allowed when converting with trang
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: sdk (show other bugs)
Version:
(earliest affected)
5.4.5.1 release
Hardware: All Linux (All)
: medium minor
Assignee: Not Assigned
URL:
Whiteboard: target:6.1.0
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-04 11:30 UTC by unhammer+dill
Modified: 2018-04-15 09:42 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description unhammer+dill 2018-04-04 11:30:48 UTC
Description:
/usr/lib/libreoffice/share/dtd/officedocument/1_0/dialog.dtd on Xubuntu 17.10 from the package libreoffice-common (Version: 1:5.4.5-0ubuntu0.17.10.5) has a semicolon on line 245 position 61 that should be a space. It makes trang[1] fail converting it into rnc.

                  dlg:scale-mode (none|isotropic|anisotropic);#IMPLIED                                                                  

should be

                  dlg:scale-mode (none|isotropic|anisotropic) #IMPLIED                                                                  


There's also a missing EMPTY in /usr/lib/libreoffice/share/dtd/officedocument/1_0/groupuinames.dtd, 

<!ELEMENT groupuinames:template-group>                                                                                            

should be

<!ELEMENT groupuinames:template-group EMPTY>                                                                                            


[1] http://www.thaiopensource.com/relaxng/trang.html

Steps to Reproduce:
1. for f in /usr/lib/libreoffice/share/dtd/officedocument/1_0/*dtd; do  java -jar trang.jar -I dtd -O rnc  "$f" "$(basename "${f%%.dtd}")".rnc;done

or use some other dtd-validation method

Actual Results:  
dtd's are not valid

Expected Results:
valid dtd's


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0
Comment 1 Buovjaga 2018-04-13 11:22:26 UTC
The first one is fixed by https://cgit.freedesktop.org/libreoffice/core/commit/?id=d9d6f805fdda16a1a51d50deaba8c3a08b606234

Please submit a patch to gerrit about the other one https://wiki.documentfoundation.org/Development/gerrit
Comment 2 unhammer+dill 2018-04-14 17:56:43 UTC
(In reply to Buovjaga from comment #1)
> The first one is fixed by
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=d9d6f805fdda16a1a51d50deaba8c3a08b606234
> 
> Please submit a patch to gerrit about the other one
> https://wiki.documentfoundation.org/Development/gerrit

Like https://gerrit.libreoffice.org/#/c/52878/ ?
Comment 3 Buovjaga 2018-04-14 18:34:24 UTC
(In reply to unhammer+dill from comment #2)
> Like https://gerrit.libreoffice.org/#/c/52878/ ?

Yeah, cool :)
Comment 4 Commit Notification 2018-04-15 09:42:47 UTC
Kevin Brubeck Unhammer committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=185f855e040b4e768f00d2ef342dea27a0b39cbd

Empty ELMENT should say EMPTY in dtd; fixes tdf#116791

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.