Created attachment 141304 [details]
File for testing (password: 1811)
When you choose to save your file with a password, it takes long time to save and open.
Steps to reproduce:
1. Create a file with a large amount of contents.
2. Save your file with a password (Edit -> Save as).
3. Try to open it.
Operating System: All
Version: 18.104.22.168.alpha0+ Master
Created attachment 141305 [details]
same file without password
Salim: you put "assigned", do you mean you're working on this as a dev?
Ok, let's fill assignee field then.
opening the test file with password, it take 7.0 seconds and without 4.0 seconds a bit slow when switching between sheets and i think its because of the many chart on every sheet
Build ID: 4ab0912cd214a4b0bdcbcdd2711b831dab9ca60a
CPU threads: 8; OS: Linux 4.14; UI render: default; VCL: kde4;
Locale: nl-BE (en_US.UTF-8); Calc: group
(In reply to Xavier Van Wijmeersch from comment #5)
> opening the test file with password, it take 7.0 seconds and without 4.0
> seconds a bit slow when switching between sheets and i think its because of
> the many chart on every sheet
> Version: 22.214.171.124.alpha0+
> Build ID: 4ab0912cd214a4b0bdcbcdd2711b831dab9ca60a
> CPU threads: 8; OS: Linux 4.14; UI render: default; VCL: kde4;
> Locale: nl-BE (en_US.UTF-8); Calc: group
Try to add a simple modification to the file with password and save it.
It will take a lot of time.
Yes, it hangs in
Build ID: 24a57e2b854a1b8b3b8533ac72a6614ee29e374a
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3;
Locale: ca-ES (ca_ES.UTF-8); Calc: group
In previous versions like
Build ID: 3ca42d8d51174010d5e8a32b96e9b4c0b3730a53
Threads 4; Ver: 4.10; Render: default;
Build ID: c15927f20d4727c3b8de68497b6949e72f9e6e9e
it hangs at import time...
The import hang was fixed by
author Mike Kaganski <email@example.com> 2017-11-07 13:33:48 +0300
committer Noel Grandin <firstname.lastname@example.org> 2017-11-07 14:26:11 +0100
commit f657454b69c813b90a8b3c1adb2feef1066dbd35 (patch)
parent 55d00081d0dc4cfa3361fa9da9389042f98773b5 (diff)
tdf#31231: properly check for SvXMLImportFlags::ALL
A regression from commit dc28e90d200a839d4017d548217ee5ce8a23f84
Adding Mike Kaganski to the loop in case Salim Habchi needs help to fix the export part...
Import = when you open the file ?
Export = when you save the file ?
Thank you very much, I will explore the tracks you gave me.
here is my commit on gerrit for this bug
I decreased the number of iterations in PBDFK2 because it was set to 100000 but it
takes a lot of time to save a file (10 min).
the problem comes from these iterations.
I put the number of iterations to 1000.
now it takes 10 sec to save a file.
the derived key is sufficient for this type of files and it is very secure if you choose a good password.
The informations below shows how long an attacker would take to cover the entire password space of a single salted hashed password.
* Comprehensive8: 4 hours 46 minutes
* 8 random lowercase letters: 12 hours
* 8 random letters: 123 days
* 8 letters + digits + punctuation OR 4 random Diceware words: 325 years
Other link: https://www.cloudberrylab.com/download/CloudBerry%20Lab%20Security%20Considerations.pdf
If you want to test this patch with the old testing file you must save at least one time the file with this patch.
I will add the same file with my patch.
Thorsten: noticing you had removed a similar loop in https://cgit.freedesktop.org/libreoffice/core/commit/?id=39805f65189cd0085fe8f1071ae75cdec450c65e, thought you might be interested in the patch proposed by Salim.
Created attachment 141448 [details]
New file with patch (password: 1811)
See also bug 105844 comment 12 & 13
*** Bug 122060 has been marked as a duplicate of this bug. ***
*** Bug 122377 has been marked as a duplicate of this bug. ***